AdSize.SMART_BANNER in C++

firebase / firebase-cpp-sdk

Firebase C++ SDK

http://firebase.google.com

Apache License 2.0

272 stars 111 forks source link

AdSize.SMART_BANNER in C++ #11

Open crazyhappygame opened 5 years ago

crazyhappygame commented 5 years ago

What is C++ code for Java AdSize.SMART_BANNER https://developers.google.com/admob/android/banner

a-maurice commented 5 years ago

Hi @crazyhappygame

Unfortunately AdSize.SMART_BANNER is currently not supported in the C++ code. If you would like to have it working locally before we add support for it, you can do so by modifying:

https://github.com/firebase/firebase-cpp-sdk/blob/021d99b74f9c5bb18d9b290557e904c55e280702/admob/src_java/com/google/firebase/admob/internal/cpp/BannerViewHelper.java#L151

to instead be: new AdSize(-1, -2, "smart_banner")

Thanks for bringing this to our attention.