firebase / firebase-cpp-sdk

Firebase C++ SDK
http://firebase.google.com
Apache License 2.0
276 stars 114 forks source link

[Bug] Crashes at RemoteConfigResponse related to FlatBufferBuilder #1348

Open feixuwu opened 1 year ago

feixuwu commented 1 year ago

[READ] For Firebase Unity SDK question, please report to Firebase Unity Sample

Once you've read this section and determined that your issue is appropriate for this repository, please delete this section.

[REQUIRED] Please fill in the following fields:

[REQUIRED] Please describe the question here:

hi, I found some crash on my customer's PC, from the minidump, the crash is like this: image the rdx is zero image

and the correspond code is image the rbx+68h get the builder the rax+170h use the builder get the buffer pointer, the crash reason is GetRoot function will try use the buffer pointer from builder_, but if the buffer pointer is null, it will crash, so I think it should do some protect like this: image

google-oss-bot commented 1 year ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

chkuang-g commented 1 year ago

Thank you for reporting this issue.

It is really odd that builder.GetBufferPointer() can return a null pointer. I'll mark this as a bug for now.

triplef commented 1 year ago

We’re seeing what looks like the same crash (in remote_config_response.cc:98). I’ve reported the details in #1433.

triplef commented 10 months ago

@chkuang-g do you have any update on this? We are seeing many users running into this on app launch when we initialize remote config. We collected all details in #1433, from what it looks like a thread safety issue.