Open Lyokone opened 1 month ago
Drive-by comment: This github repo officially documents cmake 3.7 as the minimum-supported version: https://github.com/firebase/firebase-cpp-sdk/blob/main/README.md
HOWEVER, last time I tried, when building for Android the build fails if using cmake 3.7 and I had to use cmake 3.6.
There have been a lot of great features added to cmake since 3.7 so it would be pretty nice to use a newer version as the minimum supported. For example, cmake 3.12 adds a far-better mechanism to find a Python interpreter:
find_package(Python3 COMPONENTS Interpreter REQUIRED)
Feature proposal
FlutterFire is using Firebase CPP SDK for Windows compatibility. We are getting a warning when compiling
I see that this is caused by this line: https://github.com/firebase/firebase-cpp-sdk/blob/df09d59cd0af503229ed412490e5f3938dbc2c24/release_build_files/CMakeLists.txt#L17
I'm wondering if it's needed to support this minimum CMake.
Reference issue https://github.com/firebase/flutterfire/issues/12849