firebase / firebase-cpp-sdk

Firebase C++ SDK
http://firebase.google.com
Apache License 2.0
276 stars 115 forks source link

Add null checks in Messaging task completions #1602

Closed a-maurice closed 3 months ago

a-maurice commented 3 months ago

Description

Provide details of the change, and generalize the change in the PR title above.

Add some null checks in the Android Task completion callbacks that finish Futures. Based on the callstack from https://github.com/firebase/firebase-unity-sdk/issues/1030, my guess is while there is a pending Android task, Messaging is getting cleaned up, and then when the Android task completes it does the callback, but the Future has been deleted.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

Notes

github-actions[bot] commented 3 months ago

✅  Integration test succeeded!

Requested by @a-maurice on commit 3cbccb47cc4790064c7cd7c1627364d27b1a58df Last updated: Thu Jun 6 19:03 PDT 2024 View integration test log & download artifacts