feat: update minimum CMake version to 3.5 - Githubissues

firebase / firebase-cpp-sdk

Firebase C++ SDK

http://firebase.google.com

Apache License 2.0

278 stars 114 forks source link

feat: update minimum CMake version to 3.5 #1617

Open Lyokone opened 4 months ago

Lyokone commented 4 months ago

Description

Provide details of the change, and generalize the change in the PR title above.

Updates the CMake version to 3.5. closes #1599

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Manually tested by compiling firebase cpp sdk with FlutterFire.

Type of Change

Place an x the applicable box:

[ ] Bug fix. Add the issue # below if applicable.
[ ] New feature. A non-breaking change which adds functionality.
[X] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

cynthiajoan commented 4 months ago

Do we also want to update the cmake min version for all integration_test within this PR? @jonsimantov