firebase / firebase-cpp-sdk

Firebase C++ SDK
http://firebase.google.com
Apache License 2.0
276 stars 115 forks source link

Remove unnecessary cmake quotes #1625

Closed a-maurice closed 2 months ago

a-maurice commented 2 months ago

Description

Provide details of the change, and generalize the change in the PR title above.

The GHA machines updated cmake versions, which seems to have a problem when passing in the CMAKE_OSX_ARCHITECTURES with quotes, so remove them. Note that normally when we do the call from scripts, we don't have the quotes, this is just in the part where we have cmake trigger itself for downloads.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-unity-sdk/actions/runs/9882221217


Type of Change

Place an x the applicable box:

Notes

github-actions[bot] commented 2 months ago

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit ff3561ece210e31c218bccf7e5e13a8945b4b69b Last updated: Wed Jul 10 20:23 PDT 2024 View integration test log & download artifacts Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  QueryTest.TestQueriesCanUseNotEqualFiltersWithNan
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker