Fix RemoteConfig info initialization issues - Githubissues

firebase / firebase-cpp-sdk

Firebase C++ SDK

http://firebase.google.com

Apache License 2.0

278 stars 114 forks source link

Fix RemoteConfig info initialization issues #1639

Closed a-maurice closed 2 months ago

a-maurice commented 2 months ago

Description

Provide details of the change, and generalize the change in the PR title above.

On Android, handle the underlying SDK returning a negative fetch time. On iOS, fix throttled_time initialization issues.

Fixes this Unity issue, since the incorrect values were getting added to TimeSpans, which caused exceptions to be thrown: https://github.com/firebase/firebase-unity-sdk/issues/1058

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Testing locally

Type of Change

Place an x the applicable box:

[x] Bug fix. Add the issue # below if applicable.
[ ] New feature. A non-breaking change which adds functionality.
[ ] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

github-actions[bot] commented 2 months ago

✅ Integration test succeeded!

Requested by @a-maurice on commit 09b795710f2eff760d782831bf7e63895d009295 Last updated: Fri Sep 6 15:43 PDT 2024 View integration test log & download artifacts