firebase / firebase-cpp-sdk

Firebase C++ SDK
http://firebase.google.com
Apache License 2.0
276 stars 115 forks source link

Remove unnecessary swig logic from Analytics #1641

Closed a-maurice closed 2 weeks ago

a-maurice commented 2 weeks ago

Description

Provide details of the change, and generalize the change in the PR title above.

Remove some extra swig logic that is unnecessarily in the C++ header file. The logic to add the unsafe tag was already in the Unity SDK's swig file, and it will be going away soon anyway.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

Notes

github-actions[bot] commented 2 weeks ago

⏳  Integration test in progress...

Requested by @a-maurice on commit 8716ff457bfa4fe29887375a598b23623301501c Last updated: Tue Sep 10 17:47 PDT 2024 View integration test log & download artifacts