search

firebase / firebase-functions-python

Apache License 2.0
136 stars 22 forks source link

Configure CPU-allocation, the run.googleapis.com/cpu-throttling boolean in Cloud Run #173

Open antont opened 8 months ago

antont commented 8 months ago

Hi, is it possible to somehow configure the option that Cloud Run has for CPU allocation?

It's like this in the Run YAML:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: SERVICE
spec:
  template:
    metadata:
      annotations:
        run.googleapis.com/cpu-throttling: 'BOOLEAN'
      name: REVISION

where the bool is:

BOOLEAN with true to set CPU allocation only during request processing, or false to set CPU to always allocated.

That's from https://cloud.google.com/run/docs/configuring/cpu-allocation#yaml

The Python lib here has many related options, such as cpu min-instances, and a way to set labels, but that annotations part is not mentioned in the docs, https://firebase.google.com/docs/reference/functions/2nd-gen/python/firebase_functions.options#firebase_functions.options.EventHandlerOptions

antont commented 8 months ago

Oh I think it's actually possible to set preserve_external_changes to true and then edit the autodeployed YAML manually, we'll go with this now.

Update: we failed doing this so far, though, so hints are welcome..

exaby73 commented 8 months ago

What sort of configuration options could be added here? Could you give me an example of a use case where you'd need to edit it?