search

firebase / firebase-functions-test

MIT License
232 stars 48 forks source link

Better types for auth.makeUserRecord #112

Open rhodgkins opened 3 years ago

rhodgkins commented 3 years ago

Description

Allowed partial typed UserRecord object to be specified for parameter of auth.makeUserRecord.

Code sample

N/A

rhodgkins commented 2 years ago

Can anyone review and, if happy, merge this in please?

rhodgkins commented 2 years ago

Bump @inlined & @taeold

rhodgkins commented 2 years ago

I can’t remember why I removed toJSON now :-/ I don’t think a simple Partial will be enough though as it needs to recurse down to the sub objects (like it does at the moment with metadata, etc.), otherwise they will need to be fully defined.

inlined commented 2 years ago

I wonder if we should define RecursivePartial as demonstrated here (maybe in index.ts) and then use that in UserRecord and others. What do you think about that?

rhodgkins commented 2 years ago

Yeh that’s fine with me 👍