firebase / firebase-functions-test

MIT License
232 stars 48 forks source link

Remove unnecessary lodash #130

Closed TheIronDev closed 2 years ago

TheIronDev commented 2 years ago

Description

Tech debt; Removing some unnecessary references of lodash.

Code sample

if(_.get(object, 'param'))
if(!!object.param)
TheIronDev commented 2 years ago

Requesting a review from @inlined

TheIronDev commented 2 years ago

We could almost remove lodash here. firestore.ts has a few strange things that I was going to tackle in a follow-up pr.

TheIronDev commented 2 years ago

Closing pull request, there are a bunch of conflicts that would take a bit too long to resolve..