search

firebase / firebase-functions-test

MIT License
232 stars 48 forks source link

Adds `onCall` function support (#9) #34

Closed abeisgoat closed 5 years ago

abeisgoat commented 5 years ago

Description

Adds support for https.onCall functions and improves filtering of https.onRequest functions.

Do not merge! I'm not sure if there are other aspects of this I'm missing. I'm not sure if there's any value to adding providers/https.ts other than to allow onCall support to be discoverable in the library. Since the bundles passed to the functions are arbitrary JSON I'm not sure what help we could be.

Let me know your thoughts!

Code sample

See providers/https.spec.ts

abeisgoat commented 5 years ago

Is there somewhere I can see what CallableContext should be?

abeisgoat commented 5 years ago

JK, found it I'll work on adding support for this context type and moving to lodash.

rilian commented 5 years ago

thank you for working on this!