search

firebase / firebase-functions-test

MIT License
232 stars 48 forks source link

Drop legacy import/export syntax #40

Open merlinnot opened 5 years ago

merlinnot commented 5 years ago

This package uses legacy import/export syntax, the proposal was withdrawn and this syntax should not be used:

https://github.com/firebase/firebase-functions-test/blob/a25faf5c87553b4482ce85a7dea4d11885f27cc4/src/index.ts#L29

https://github.com/firebase/firebase-functions-test/blob/c77aa92d345b8e4fb5ad98534989eb8dcf7d9bc4/spec/providers/https.spec.ts#L3

We could either use default export, or preferably a named one, but it would be a breaking change, so I won't make a PR before we align on this.

abeisgoat commented 5 years ago

Absolutely agreed, I'll probably snap this twig on the next major release.

merlinnot commented 4 years ago

@abeisgoat Is this package still maintained? Is it worth to start making PRs?

laurenzlong commented 4 years ago

Hey @merlinnot sorry for the long silence! We've definitely dropped the ball on our side, and will start showing this repo some more love. Yes you're very welcome to start making PRs, and we'd be happy to review.