search

firebase / firebase-functions-test

MIT License
232 stars 48 forks source link

Cleanup config after test run #68

Closed rgant closed 3 years ago

rgant commented 4 years ago

Description

I need to change the firebase functions configuration sometimes while testing and there is no clear documentation on how to do that. I've added a test case that fails when changing the functions config between test runs, and a fix to the test configuration fix the test.

However, I am not sure if that is the way it should be done. I was surprised that the cleanup function didn't do this and thought about adding this step to that. However the cleanup function doesn't have anything to do with functions config right now so I wasn't sure if that was desirable. If that is the way this should be done then I would be happy to modify this pull request to do that.

Details

firebase-functions only inits the config one time, and otherwise uses a singleton object. So just deleting the process.env.CLOUD_RUNTIME_CONFIG during test runs is insufficient. You must also delete the functions.config.singleton object.

joehan commented 3 years ago

This was duped by #74, so I'll close this. Thank you for contributing!