search

firebase / firebase-functions

Firebase SDK for Cloud Functions
https://firebase.google.com/docs/functions/
MIT License
1.02k stars 201 forks source link

Please move `node-fetch` as a `devDependency` #1542

Closed if-fi closed 6 months ago

if-fi commented 6 months ago

Related issues

[REQUIRED] Version info

node:

v18.18.0

firebase-functions:

v4.8.1

firebase-tools:

13.5.2

firebase-admin:

11.11.1

[REQUIRED] Test case

We are trying to upgrade node-fetch to v3.X.X, but the firebase-functions package has pinned as a dependency v2.X.X. As far as I can see, you only use node-fetch for tests. Could you please move the node-fetch dependency as a devDependency so it does not prevent packages that depend on firebase-functions from upgrading.

[REQUIRED] Steps to reproduce

Add firebase-functions as a dependency to a project which depends on node-fetch v3.X.X

[REQUIRED] Expected behavior

The project cannot use node-fetch v3.X.X

[REQUIRED] Actual behavior

If you put node-fetch v2.X.X in devDependencies of firebase-functions, it will still be used in tests, but it will not prevent other projects from upgrading.

Were you able to successfully deploy your functions?

google-oss-bot commented 6 months ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.