search

firebase / firebase-functions

Firebase SDK for Cloud Functions
https://firebase.google.com/docs/functions/
MIT License
1.03k stars 204 forks source link

Firebase Functions v2 missing labels for documentOnwritten #1566

Open jobweegink opened 6 months ago

jobweegink commented 6 months ago

Related issues

1331

[REQUIRED] Version info

node:20.11.1

firebase-functions:5.0.1

firebase-tools:13.5.2

firebase-admin:12.1.0

[REQUIRED] Test case

In a onDocumentWritten Cloud Function V2 in the logs panel when clicking "Show entries from this trace", only one log is shown.

[REQUIRED] Steps to reproduce

Deploy a onDocumentWritten Cloud function gen2, trigger it by changing a document in firestore. Go to logs Find the corresponding log click "Show entries from this trace"

[REQUIRED] Expected behavior

In Cloud function v1 it was very easy to group them by ExecutionID, this is no longer possible in V2 image Issue #1331 suggested "Show entries from this trace" howevert this is showing only that specific log, not all the other logs related to that execution

[REQUIRED] Actual behavior

Only one log is showing

Were you able to successfully deploy your functions?

Yes

google-oss-bot commented 6 months ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

exaby73 commented 6 months ago

Hey @jobweegink. Could you give a code sample which I can use to investigate and debug?

jobweegink commented 6 months ago

Sure, see below, the console logs 'hi' and 'there' wont be grouped when clicking "Show entries from this trace"

import {
  onDocumentWritten,
  Change,
  FirestoreEvent
} from "firebase-functions/v2/firestore";

exports.myfunction = onDocumentWritten("someCollection/{recordId}", (event) => {
  console.log('hi')
  console.log('there')
});
exaby73 commented 4 months ago

This may be fixed by https://github.com/firebase/firebase-functions/pull/1533