firebase / firebase-functions

Firebase SDK for Cloud Functions
https://firebase.google.com/docs/functions/
MIT License
1.03k stars 204 forks source link

Firebase Crashlytics - Cannot use dynamic params for declaring appId #1597

Open BenjaminBihr opened 3 months ago

BenjaminBihr commented 3 months ago

Related issues

I couldn't find any related issues.

Version info

node: 20

firebase-functions: 5.0.0

firebase-tools: 13.15.2

Test case


import {defineString} from "firebase-functions/params";
import {onVelocityAlertPublished} from "firebase-functions/v2/alerts/crashlytics";
import {logger} from "firebase-functions";

const APP_ID = defineString('APP_ID');

export const detectVelocityAlert = onVelocityAlertPublished({
  appId: APP_ID,
}, async (event) => {
  logger.log("New velocity alert spotted!");
});

Steps to reproduce

  1. Create a Cloud Function using onVelocityAlertPublished.
  2. Define the appId using defineString('APP_ID') from firebase-functions/params.
  3. Attempt to deploy or run the function.

Expected behavior

I expect the function to accept a parameter defined via defineString('APP_ID') for the appId in the onVelocityAlertPublished function configuration.

Actual behavior

When I try to use defineString('APP_ID') to set the appId, the function fails to deploy because it appears to only accept a string literal, not a StringParams.

Were you able to successfully deploy your functions?

No, the deployment fails.

google-oss-bot commented 3 months ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

exaby73 commented 3 months ago

Hello @BenjaminBihr. Thanks for bringing this up. Seems a valid feature request