firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.65k stars 1.48k forks source link

[FR]: Performance: Allow adding custom attributes to built-in traces #10291

Open mikeger opened 2 years ago

mikeger commented 2 years ago

Description

Firebase performance is tracking the number of built-in events, such as

Currently, it is not possible to assign custom attributes to those traces. It would be great to allow this. Luckily, it is a mere question of making an API public.

API Proposal

Performance class has private compliance to PerformanceAttributable (FRPerformanceAttributable). If this compliance would be public, it would be possible to set the attributes on the Performance singleton, which are in turn propagated as default attributes for all traces.

Firebase Product(s)

Performance

google-oss-bot commented 2 years ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

bidrohi commented 1 year ago

This is already available to use in the Android SDK, so would be great to have it in the iOS one too.