search

firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.53k stars 1.44k forks source link

Security Policy violation Binary Artifacts #10577

Closed google-allstar-prod[bot] closed 1 year ago

google-allstar-prod[bot] commented 1 year ago

This issue was automatically created by Allstar.

Security Policy Violation Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps To remediate, remove the generated executable artifacts from the repository.

First 10 Artifacts Found

Additional Information This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

:warning: There is an updated version of this policy result! Click here to see the latest update

Allstar has been installed on all Google managed GitHub orgs. Policies are gradually being rolled out and enforced by the GOSST and OSPO teams. Learn more at http://go/allstar

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

samedson commented 1 year ago

This is unit test data, not compiled into the release. Going to exempt these files

samedson commented 1 year ago

This list isn't complete. I was able to get the full list by going to bigquery. The instructions are: https://github.com/ossf/scorecard#public-data

My query was:

SELECT * FROM `openssf.scorecardcron.scorecard-v2` WHERE repo.name="github.com/firebase/firebase-ios-sdk" ORDER BY date DESC LIMIT 1
""Warn: binary detected: Crashlytics/UnitTests/Data/10.9.3_libobjc.A.dylib:1""
""Warn: binary detected: Crashlytics/UnitTests/Data/10.9.4_libsystem_kernel.dylib:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/armv7-armv7s-arm64.dylib:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/armv7-armv7s-executable:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/armv7-armv7s.dSYM/Contents/Resources/DWARF/CrashTest:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/armv7k:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/i386-simulator.dSYM/Contents/Resources/DWARF/CrashTest:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/tvos-binary:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/tvsimulator-binary:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/watchOS-simulator:1""
""Warn: binary detected: Crashlytics/UnitTests/FIRCLSMachO/data/x86_64-executable:1""
""Warn: binary detected: Crashlytics/upload-symbols:1""
""Warn: binary detected: FirebaseAppDistribution/Tests/Unit/Resources/armv7-armv7s-executable:1""
""Warn: binary detected: FirebaseAppDistribution/Tests/Unit/Resources/x86_64-executable:1""
""Warn: binary detected: ReleaseTooling/Template/dummy_Firebase_lib:1""
Screen Shot 2022-12-15 at 2 50 09 PM
google-allstar-prod[bot] commented 1 year ago

The policy result has been updated.

Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

Additional Information This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.