firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.56k stars 1.45k forks source link

FIRDynamicLinkNetworking.m ungracefully throwing exceptions #11423

Closed demonar closed 1 year ago

demonar commented 1 year ago

Description

when calling:

(BOOL)handleUniversalLink:(NSURL *)universalLinkURL completion:(FIRDynamicLinkUniversalLinkHandler)completion

with a link that does not contain the api key, the internal calls to

(instancetype)initWithAPIKey:(NSString )APIKey URLScheme:(NSString )URLScheme

generate an exception, this exception cannot be catched as the calls are not marked as throwable

Reproducing the issue

call (BOOL)handleUniversalLink:(NSURL *)universalLinkURL completion:(FIRDynamicLinkUniversalLinkHandler)completion with a link that does not contain the api key

Firebase SDK Version

10.10.0

Xcode Version

14.3

Installation Method

Swift Package Manager

Firebase Product(s)

DynamicLinks

Targeted Platforms

iOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet
```json Replace this line with the contents of your Package.resolved. ```

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet
```yml Replace this line with the contents of your Podfile.lock! ```
google-oss-bot commented 1 year ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

paulb777 commented 1 year ago

The Firebase Dynamic Links service will be shutdown on August 25, 2025. In the meantime, only critical or security issues will be fixed in the SDK.

More at https://firebase.google.com/support/dynamic-links-faq