firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.47k stars 1.43k forks source link

[FR]: Add a Swift Package Plugin for Crashlytics DSYM uploads #11992

Open BrentMifsud opened 8 months ago

BrentMifsud commented 8 months ago

Description

With Swift package plugin support, now widely available, it would be nice to have the Crashlytics DSYM upload script available as a package plugin.

Today we have to setup a build phase for this.

With a package plugin, the setup would be integrated into Xcode. Making onboarding much easier for new users.

API Proposal

n/a

Firebase Product(s)

Crashlytics

google-oss-bot commented 8 months ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

samedson commented 7 months ago

Hey @BrentMifsud - thanks for the suggestion. Was doing some digging and from https://github.com/apple/swift-package-manager/blob/main/Documentation/Plugins.md, it looks like Package Plugins will be restricted from accessing the network.

This would prevent upload-symbols from sending symbols to Crashlytics. I need to do some digging to see if there's a way to get the user's permission, but if someone has information about this it would be helpful for our exploration.

Screenshot 2023-11-22 at 2 06 00 PM
BrentMifsud commented 7 months ago

Ah that's unfortunate. I didn't realize they put network limitations on package plugins.

samedson commented 7 months ago

Yeah, was definitely excited about this feature for this use case. But I guess for now I'll leave this open in case anyone finds something out that unblocks this.

SwiftNativeDeveloper commented 4 months ago

Has anyone opened up a feedback to Apple on this to allow plugins to talk to the rest of the world?