firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.41k stars 1.42k forks source link

[v11] Add convenience initializer #13136

Closed ncooke3 closed 1 week ago

google-oss-bot commented 1 week ago
1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

ncooke3 commented 1 week ago

This marks the end of any public APIs (besides properties due to challenges with them) that have providerID: String.

ncooke3 commented 1 week ago

Open to thoughts on next steps... one step further would be to change the internal usage of providerID to AuthProviderID. The issue there is that we will have to explicitly have to go from StringAuthProviderID which means we have to handle the case where a String doesn't map to AuthProviderID. Probably would need to create and throw an "invalid providerID" error.