search

firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.58k stars 1.46k forks source link

My Mac Game was rejected because Google Sign in does web based login? Can I do anything other than removing Google on Mac? #13146

Closed andytriboletti closed 3 months ago

andytriboletti commented 3 months ago

Description

My Mac Game Open Space was rejected from TestFlight because it uses Google login, which does browser sign-in. Do I have to remove Google sign-in? I already have Apple sign-in as well as Google.

Guideline 4.0 - Design

The user is taken to the default web browser to sign in or register (Google) for an account, which provides a poor user experience.

Next Steps

To resolve this issue, revise the submission to enable users to sign in or register for an account in the app or extension.

The whole reason I added Google sign in on my TestFlight was that Apple sign in wouldn't work on my Mom's macbook air, while Google does.

Reproducing the issue

No response

Firebase SDK Version

current

Xcode Version

15.4

Installation Method

CocoaPods

Firebase Product(s)

Authentication

Targeted Platforms

macOS

Relevant Log Output

No response

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet
```json Replace this line with the contents of your Package.resolved. ```

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet
```yml Replace this line with the contents of your Podfile.lock! ```
google-oss-bot commented 3 months ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

andytriboletti commented 3 months ago

I am using FirebaseAuthUI

paulb777 commented 3 months ago

Is the rejection due to Firebase Auth UI code or to Google Sign In code? If so, this issue might be better addressed on those issue trackers.

andytriboletti commented 3 months ago

Is the rejection due to Firebase Auth UI code or to Google Sign In code? If so, this issue might be better addressed on those issue trackers.

I'm not sure. Can you please transfer the ticket to the one u think is right.

ncooke3 commented 3 months ago

Hi @andytriboletti, I investigated and this issues belongs in the Google Sign In repo. Instead of moving it though, I will close it as there is an already an issue filed there about this: https://github.com/google/GoogleSignIn-iOS/issues/388

I recommend reading through it as some developers reported success after reaching out to Apple about the review feedback.