firebase / firebase-ios-sdk

Firebase SDK for Apple App Development

https://firebase.google.com

Apache License 2.0

5.41k stars 1.42k forks source link

[Messaging] Fix APS Environment entitlement key on visionOS #13176

Closed andrewheard closed 3 days ago

andrewheard commented 3 days ago

On visionOS we should use the APS Entitlement Key aps-environment, not com.apple.developer.aps-environment (macOS only -- excluding Catalyst). This should fix #13173.

Note: Previously TARGET_OS_IOS was true on visionOS but not as of Xcode 15.2.

google-oss-bot commented 3 days ago

<!DOCTYPE html>

Coverage Report ¹

Affected Products

FirebaseMessaging-iOS-FirebaseMessaging.framework
Overall coverage changed from 60.17% (04f0491) to 60.22% (0c430aa) by +0.05%.
Filename Base (04f0491) Merge (0c430aa) Diff
FIRMessagingCheckinPreferences.m 93.07% 98.02% +4.95%
FIRMessagingPendingTopicsList.m 90.59% 89.80% -0.78%

Test Logs

Base (04f0491): https://github.com/firebase/firebase-ios-sdk/actions/runs/9602737789
Merge (0c430aa): https://github.com/firebase/firebase-ios-sdk/actions/runs/9652012522