firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.56k stars 1.45k forks source link

[Auth] Await header value from underlying queue #13647

Closed ncooke3 closed 4 days ago

ncooke3 commented 4 days ago

Follow-up to https://github.com/firebase/firebase-ios-sdk/pull/13521 that may solve an issue reported after rolling out that fix: https://github.com/firebase/firebase-ios-sdk/issues/13480#issuecomment-2351567621

google-oss-bot commented 4 days ago
1 Warning
:warning: Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

ncooke3 commented 4 days ago

After some profiling, it doesn't appear that heartbeat work (via the get App Check token call later down in this method) will be executed on the concurrent coop queue. So, this should PR should be sufficient as is.