firebase / firebase-ios-sdk

Firebase SDK for Apple App Development

https://firebase.google.com

Apache License 2.0

5.56k stars 1.45k forks source link

[Vertex AI] Remove `SafetyFeedback` struct #13666

Closed andrewheard closed 2 days ago

andrewheard commented 2 days ago

Removed the SafetyFeedback struct from the Vertex AI SDK since it isn't used anywhere. This also means that SafetyRating.HarmProbability, SafetySetting and SafetySetting.BlockThreshold and no longer need to be Codable since they are exclusively used for request (Encodable) or response (Decodable) types.

no-changelog

andrewheard commented 2 days ago

@paulb777 Should this have a changelog entry? Although it was completely useless it was a public struct.

andrewheard commented 2 days ago

No changelog necessary if there was no practical usage of the public APIs

SGTM

Looks like SPM is still broken on GHA

I noticed earlier with Nick's PR that it did work on re-run (seems to be running here now too) so the GHA failures are intermittent.