search

firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.47k stars 1.43k forks source link

FR: Officially support Carthage release #1862

Closed Nonnus closed 5 years ago

Nonnus commented 5 years ago

As it is obvious this is not really an issue but I really wanted to leave some feedback about your experimental carthage integration as I really hope it ends up being officially supported!

ps: feel free to close this issue :)

pps: sorry if I am abusing the issues guidelines, I hope the end justified the means ;)

morganchen12 commented 5 years ago

No problem!

paulb777 commented 5 years ago

The Carthage distribution is still experimental and we're not promising to make every minor release available via Carthage.

Even if the latest distribution is not available via Carthage, the latest binary frameworks are always available at https://firebase.google.com/docs/ios/setup#frameworks.

We're continuing to improve the release process and hope to make Carthage official and in sync with the rest of the release in the future.

learnwithgabbar commented 5 years ago

Where is the development process to support carthage

paulb777 commented 5 years ago

@techmehra See https://github.com/firebase/firebase-ios-sdk/tree/master/ZipBuilder for the zip and Carthage libraries are build scripts. There is additional internal code for deploying the libraries to Google servers.

mmalesevic commented 5 years ago

@paulb777 when will "make Carthage official and in sync with the rest of the release in the future" happen? Mid 19 or End 19? As Fabric.io isn't a optiona any longer i have to know how to handle future projects... and pods is not a option as we are using carthage in most of our projects...

paulb777 commented 5 years ago

@mmalesevic We've been making progress and are now consistently recently Carthage within a day of the CocoaPods releases. However, we still need better staging and testing infrastructure before we can make Carthage support official. I'm hoping that it can happen in the next few months, but can't make any promises.

ffittschen commented 5 years ago

Linking this issue as cross-reference, because it should be taken into consideration when providing official Carthage support: https://github.com/Carthage/Carthage/issues/2777

Hantok commented 5 years ago

Just moved Firebase from pods to carthage in one project. Is it possible to use specific Firebase version in carthage to be sure all things work fine?

mortenbekditlevsen commented 5 years ago

Yes, you can specify the dependency in the Cartfile as follows: binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseDatabaseBinary.json" == 6.2.0

paulb777 commented 5 years ago

Closing. Now that Swift Package Manager is the future (see #3136), we no longer plan to officially support Carthage. We will continue Carthage updates and support as experimental until SPM migration is ready.

AlexisQapa commented 5 years ago

Since you don't plan on open sourcing all you frameworks isn't Carthage the best bet for now ? Using SPM with binary isn't even drafted

paulb777 commented 5 years ago

We plan to continue existing CocoaPods, zip, and Carthage support. After WWDC 2019, we think that investing in a swiftPM solution is better than further Carthage improvements.

AlexisQapa commented 5 years ago

Nice to know, we will definitely move to SPM when available too. I was just worried you would drop Carthage support right now as we spent quite a lot of time investing in Carthage related tooling.

mendesbarreto commented 4 years ago

I'd really like to see this support comes true yet, because even though SPM is already being adopted for you guys, but it still does not have the support for Binaries Distribution which ultimately reduces compilation time.

I'd to invite you to compare the diferences between a medium-sized project based on cocoapods and SPM and one which has prebuilt carthage frameworks, you will notice the difference and I can guarantee that it is not a small one and because that I think Carthage is a big deal yet.

Thanks for everything you ever did for us that still use carthage!

agustr commented 4 years ago

Im new to carthage but like it. Seems a bit cleaner and clearer than what the pod installation. I am having some trouble though with this since I am working on a project that uses older versions of certain firebase libraries (manually copied into the project) and for that reason I can not use this as is. I intend to update and migrate though so I definitely would prefer carthage support.