firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.67k stars 1.49k forks source link

Firebase dynamic link fails fingerprint match in certain locale/language combinations #233

Closed nhuomtv closed 6 years ago

nhuomtv commented 7 years ago

I tested ios 4.1.0 in 10 devices ios, three device receive dynamic link "MyAppSchema://google/link/?dismiss=1&is_weak_match=1". Please check new release firebase dynamic link service. May 2017 i tested with 10 device above it work normaly. Now three device dynamic link not work.

morganchen12 commented 6 years ago

@jieatgstdev please add necessary debugging information as mentioned in the above comment as well as your Podfile.lock contents. Otherwise, we cannot help you.

rostopira commented 6 years ago

I can confirm, that it seems to be fixed for me as well Thanks

Michael-Kr commented 6 years ago

According to this - "You can bypass the app preview page by specifying the dynamic link parameter efr=1. Note that without the app preview page, Dynamic Links cannot be received as unique matches on iOS.". The links will not work without a preview page, so I don't understand what exactly was fixed.

OleksiyA commented 6 years ago

@Michael-Kr Firebase Dynamic links recently shipped "copy unique match". This require AppPreview page to be enabled (efr absent or efr=0). This match 100% guarantees that user who tapped on link is the same user who launching the App.

This GitHub issue is about unreliable fingerprint match. This match is quite precise, but this match can't guarantee 100%. If you still having issue after updating Firebase Dynamic Links SDK, please open Firebase bug/support request.

HiramKarim commented 6 years ago

@paulb777 I have an error when I add firebase dynamic links to my project, My app receive notification through firebase but when I add dynamic links my app doesn't get the notifications and It crash suddenly, I don't know why, the new versions of firebase core and dynamics links fixed this error for iOS 11? (Firebase 4.8.1 and FirebaseDynamicLinks 2.3.2)

mevdev commented 6 years ago

@OleksiyA On clicking the the dynamic link it opens my app and it deep links correctly one time. The second time it gives me the BS dismiss=1 weak=1 link that is unuseful to me. Can I just get the full URL from that so that deep linking will work the 2nd time?

I understand that in some instances you would only want to deep link once, like to pick up a deferred link, but it is a DEEP link which I want to work every time I do it. It works totally fine if the app is already open!

I want the full link instead of that weak sauce on successive cold launches. Can I get that? Is it stored? Can I match it up?

morganchen12 commented 6 years ago

Hey all,

Please don't add +1 comments without any additional debugging information, especially when there are specifically-outlined information snippets mentioned in previous comments that are required for effectively debugging your issues.

If you're continuing to struggle with dynamic links after upgrading to the latest version, please open a new issue with all the appropriate diagnostic information and we'll try to help.