firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.57k stars 1.45k forks source link

Protobuf crash on 32-bit devices in PHTFlatFilePhenotype and Firestore (leveldb) #3851

Closed fangyuxi closed 5 years ago

fangyuxi commented 5 years ago

I'm using firebase 6.8.1 When new App is released at Appstore, I found more crashs appear in firebase dashboard. I do not use ProtoBuf directly I updated all Pods, before upload package to Appstore. All componets are newest.

Crashed: PHTFlatFilePhenotype
0  Protobuf                       0x160efd8 GPBCodedInputStreamReadDouble + 88 (GPBUtilities_PackagePrivate.h:88)
1  Protobuf                       0x160efd1 GPBCodedInputStreamReadDouble + 103 (GPBCodedInputStream.m:103)
2  Protobuf                       0x1639fd1 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2143 (GPBMessage.m:2143)
3  Protobuf                       0x160f9c5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
4  Protobuf                       0x163a47f MergeRepeatedNotPackedFieldFromCodedInputStream + 2294 (GPBMessage.m:2294)
5  Protobuf                       0x1639f6b -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2393 (GPBMessage.m:2393)
6  Protobuf                       0x160f9c5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
7  Protobuf                       0x163a47f MergeRepeatedNotPackedFieldFromCodedInputStream + 2294 (GPBMessage.m:2294)
8  Protobuf                       0x1639f6b -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2393 (GPBMessage.m:2393)
9  Protobuf                       0x160f9c5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
10 Protobuf                       0x163a47f MergeRepeatedNotPackedFieldFromCodedInputStream + 2294 (GPBMessage.m:2294)
11 Protobuf                       0x1639f6b -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2393 (GPBMessage.m:2393)
12 Protobuf                       0x1639647 -[GPBMessage mergeFromData:extensionRegistry:] + 1928 (GPBMessage.m:1928)
13 Protobuf                       0x1636d55 -[GPBMessage initWithData:extensionRegistry:error:] + 868 (GPBMessage.m:868)
14 Protobuf                       0x163971b +[GPBMessage parseFromData:extensionRegistry:error:] + 1957 (GPBMessage.m:1957)
15 Protobuf                       0x16396e5 +[GPBMessage parseFromData:error:] + 1951 (GPBMessage.m:1951)
16 SparkMusic                     0x526773 __69-[PHTHeterodyneSyncer syncAccount:syncedScopes:fetchReason:callback:]_block_invoke_2 + 4831091
17 libdispatch.dylib              0x1b461797 _dispatch_call_block_and_release + 10
18 libdispatch.dylib              0x1b46e59d _dispatch_queue_serial_drain + 854
19 libdispatch.dylib              0x1b464b71 _dispatch_queue_invoke + 886
20 libdispatch.dylib              0x1b46ea1f _dispatch_queue_override_invoke + 282
21 libdispatch.dylib              0x1b4701b5 _dispatch_root_queue_drain + 326
22 libdispatch.dylib              0x1b47000f _dispatch_worker_thread3 + 106
23 libsystem_pthread.dylib        0x1b61687d _pthread_wqthread + 1040
24 libsystem_pthread.dylib        0x1b61645c start_wqthread + 8

This is the details of the App that has Crash.

-Xcode Version 10.2.1 
-Base SDK iOS 12.2
-Crash iOS Version iOS9, iOS10 only.

The pod install info.

Installing AFNetworking (3.2.1)
Installing BoringSSL-GRPC (0.0.3)
Installing CYLTabBarController (1.28.3)
Installing Crashlytics (3.14.0)
Installing DeviceUtil (5.1.0)
Installing FBAudienceNetwork (5.5.0)
Installing FBSDKCoreKit (5.5.0)
Installing FBSDKLoginKit (5.5.0)
Installing Fabric (1.10.2)
Installing Firebase (6.8.1)
Installing FirebaseABTesting (3.1.1)
Installing FirebaseAnalytics (6.1.1)
Installing FirebaseAnalyticsInterop (1.4.0)
Installing FirebaseAuth (6.2.3)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (6.2.3)
Installing FirebaseCoreDiagnostics (1.0.1)
Installing FirebaseCoreDiagnosticsInterop (1.0.0)
Installing FirebaseDatabase (6.1.0)
Installing FirebaseFirestore (1.5.0)
Installing FirebaseInstanceID (4.2.5)
Installing FirebaseMessaging (4.1.4)
Installing FirebasePerformance (3.1.4)
Installing FirebaseRemoteConfig (4.4.0)
Installing FirebaseStorage (3.4.1)
Installing FirebaseUI (8.0.4)
Installing GTMSessionFetcher (1.2.2)
Installing Google-Mobile-Ads-SDK (7.49.0)
Installing GoogleAppMeasurement (6.1.1)
Installing GoogleDataTransport (1.2.0)
Installing GoogleDataTransportCCTSupport (1.0.3)
Installing GoogleMobileAdsMediationFacebook (5.5.0.0)
Installing GoogleSignIn (4.4.0)
Installing GoogleToolboxForMac (2.2.1)
Installing GoogleUtilities (6.2.5)
Installing IQKeyboardManager (6.4.2)
Installing KVOController (1.2.0)
Installing LEEAlert (1.2.8)
Installing MJRefresh (3.2.0)
Installing MOBFoundation (3.2.5)
Installing Masonry (1.1.0)
Installing NMEasyTipView (1.2)
Installing Protobuf (3.9.0)
Installing RTRootNavigationController (0.7.1)
Installing Reachability (3.2)
Installing ReactiveCocoa (2.5)
Installing SDWebImage (5.1.1)
Installing SJBaseVideoPlayer (2.7.1)
Installing SJUIKit (0.0.0.35)
Installing SVProgressHUD (2.2.5)
Installing TOWebViewController (2.2.8)
Installing TTGTagCollectionView (1.11.1)
Installing YYCache (1.0.4)
Installing YYCategories (1.0.4)
Installing YYModel (1.0.4)
Installing gRPC-C++ (0.0.9)
Installing gRPC-Core (1.21.0)
Installing leveldb-library (1.22)
Installing lottie-ios (2.5.3)
Installing mob_sharesdk (4.3.2)
Installing nanopb (0.3.901)
Installing youtube-ios-player-helper (0.1.6)
google-oss-bot commented 5 years ago

I found a few problems with this issue:

paulb777 commented 5 years ago

Please share the Podfile and Podfile.lock. Also, any other patterns in where the crashes occur like iOS versions, etc.

neilmorton commented 5 years ago

I am seeing the same crash on 2 apps.

@paulb777 The crashes I am seeing appear to be from iOS 9 and iOS 10 only on both apps. Also, these builds were compiled with the Xcode 11 GM Seed.

@fangyuxi what version of Xcode did you compile the build with? (Just wondering if other users haven’t spotted this yet, or if it is an issue compiling against the Xcode 11 GM seed?)

fangyuxi commented 5 years ago

@neilmorton The Xcode version is 10.3. Not Xcode 11 GM. Now, this problem has caused a lot of Crash. (Just wondering if other users haven’t spotted this yet)

@paulb777 The specific compilation environment and podfile or podfile lock will be available to you tomorrow.

neilmorton commented 5 years ago

@fangyuxi That’s interesting about the Xcode version. Can you see what versions of iOS are affected for you? Are you seeing it limited to iOS 9 and 10?

fangyuxi commented 5 years ago

@neilmorton Yes iOS 9 and iOS 10 Only

fangyuxi commented 5 years ago

@neilmorton Now I am concerned about whether this Crash will cause iOS 9 and iOS 10 users to not use the App properly(I don't have an iPhone for iOS9 or iOS 10 to test.). If the user only occasionally encounters this Crash, then we still have time to fix it.

neilmorton commented 5 years ago

@fangyuxi ok. I was limiting Firebase to 6.5.0 before my latest build due to a previous issue. I thought that was fixed, but seems there is now a new issue. I am going to limit the pod file back to 6.5.0 and resubmit whilst this gets figured out.

neilmorton commented 5 years ago

@fangyuxi Looking at the data in Fabric I am sufficiently concerned by the number of iOS 9 / 10 users affected that I am reverting to the Firebase build that I had limited to due to the past issues.

Podfile update: pod 'Firebase/Core', '~> 6.5.0'

fangyuxi commented 5 years ago

@neilmorton Please check to see if these versions are stable? Thank you very much !

Installing AFNetworking (3.2.1) Installing AppLovinSDK (6.8.0) Installing BoringSSL-GRPC (0.0.3) Installing CYLTabBarController (1.28.3) Installing Crashlytics (3.14.0) Installing DeviceUtil (5.1.0) Installing FBAudienceNetwork (5.5.0) Installing FBSDKCoreKit (5.6.0) Installing FBSDKLoginKit (5.6.0) Installing Fabric (1.10.2) Installing Firebase (6.5.0) Installing FirebaseABTesting (3.1.1) Installing FirebaseAnalytics (6.0.4) Installing FirebaseAnalyticsInterop (1.4.0) Installing FirebaseAuth (6.2.1) Installing FirebaseAuthInterop (1.0.0) Installing FirebaseCore (6.1.0) Installing FirebaseDatabase (6.0.0) Installing FirebaseFirestore (1.4.2) Installing FirebaseInstanceID (4.2.5) Installing FirebaseMessaging (4.1.1) Installing FirebasePerformance (3.1.1) Installing FirebaseRemoteConfig (4.2.1) Installing FirebaseStorage (3.4.1) Installing FirebaseUI (8.0.4) Installing Flurry-iOS-SDK (9.3.1) Installing GTMSessionFetcher (1.2.2) Installing Google-Mobile-Ads-SDK (7.49.0) Installing GoogleAppMeasurement (6.0.4) Installing GoogleMobileAdsMediationAppLovin (6.8.0.0) Installing GoogleMobileAdsMediationFacebook (5.5.0.0) Installing GoogleMobileAdsMediationInMobi (7.3.2.0) Installing GoogleMobileAdsMediationMoPub (5.7.1.0) Installing GoogleSignIn (4.4.0) Installing GoogleToolboxForMac (2.2.1) Installing GoogleUtilities (6.2.5) Installing IQKeyboardManager (6.4.2) Installing InMobiSDK (7.3.2) Installing KVOController (1.2.0) Installing LEEAlert (1.2.8) Installing MJRefresh (3.2.0) Installing MOBFoundation (3.2.5) Installing Masonry (1.1.0) Installing NMEasyTipView (1.2) Installing Protobuf (3.9.0) Installing RTRootNavigationController (0.6.7) Installing Reachability (3.2) Installing ReactiveCocoa (2.5) Installing SDWebImage (5.1.1) Installing SJBaseVideoPlayer (2.7.1) Installing SJUIKit (0.0.0.35) Installing SVProgressHUD (2.2.5) Installing TOWebViewController (2.2.8) Installing TTGTagCollectionView (1.11.1) Installing YYCache (1.0.4) Installing YYCategories (1.0.4) Installing YYModel (1.0.4) Installing gRPC-C++ (0.0.9) Installing gRPC-Core (1.21.0) Installing leveldb-library (1.22) Installing lottie-ios (2.5.3) Installing mob_sharesdk (4.3.2) Installing mopub-ios-sdk (5.7.1) Installing nanopb (0.3.901)

neilmorton commented 5 years ago

@fangyuxi I am not sure what you want me to check, but what I can say is that the current config (with the issue) is:

Installing Firebase 6.8.1 (was 6.5.0)
Installing FirebaseABTesting 3.1.1 (was 3.1.0)
Installing FirebaseAnalytics 6.1.1 (was 6.0.4)
Using FirebaseAnalyticsInterop (1.4.0)
Installing FirebaseCore 6.2.3 (was 6.1.0)
Installing FirebaseCoreDiagnostics (1.0.1)
Installing FirebaseCoreDiagnosticsInterop (1.0.0)
Installing FirebaseInstanceID 4.2.5 (was 4.2.3)
Installing FirebasePerformance 3.1.4 (was 3.1.1)
Installing FirebaseRemoteConfig 4.4.0 (was 4.2.1)
Using GTMSessionFetcher (1.2.2)
Installing GoogleAppMeasurement 6.1.1 (was 6.0.4)
Installing GoogleDataTransport (1.2.0)
Installing GoogleDataTransportCCTSupport (1.0.3)
Using GoogleToolboxForMac (2.2.1)
Using GoogleUtilities (6.2.5)
Using Protobuf (3.9.0)
Using nanopb (0.3.901)

I have now locked Firebase back to 6.5.0 (reverted to what I was running previously):

Installing Firebase 6.5.0 (was 6.8.1)
Using FirebaseABTesting (3.1.1)
Installing FirebaseAnalytics 6.0.4 (was 6.1.1)
Using FirebaseAnalyticsInterop (1.4.0)
Installing FirebaseCore 6.1.0 (was 6.2.3)
Using FirebaseInstanceID (4.2.5)
Installing FirebasePerformance 3.1.1 (was 3.1.4)
Installing FirebaseRemoteConfig 4.2.1 (was 4.4.0)
Using GTMSessionFetcher (1.2.2)
Installing GoogleAppMeasurement 6.0.4 (was 6.1.1)
Using GoogleToolboxForMac (2.2.1)
Using GoogleUtilities (6.2.5)
Using Protobuf (3.9.0)
Using nanopb (0.3.901)
Removing FirebaseCoreDiagnostics
Removing FirebaseCoreDiagnosticsInterop
Removing GoogleDataTransport
Removing GoogleDataTransportCCTSupport

I have done this as there wasn't an issue previously and I want the iOS 9 and iOS 10 users back up and running.

Looking at your information, it seems that you have Installing FirebaseCore (6.1.0) shown.

Have you added the pod 'Firebase/Core', '~> 6.5.0' to your Podfile instead of the default and run pod update to get to this config? If so, then looking at the associated versions, then this looks to match with mine.

I hope this helps.

fangyuxi commented 5 years ago

@neilmorton OK Thank you.

paulb777 commented 5 years ago

I believe that the backtrace shown would only come from FirebasePerformance. Would you confirm if removing FirebasePerformance makes the crash stop occurring?

fangyuxi commented 5 years ago

@paulb777

It seems that this Crash only come from FirebasePerformance, but now I am ready to roll back the version to 6.7.0. Because there are too many users showing this Crash.I guess that after removing FirebasePerformance, the Crash should not appear, but updating the app version takes time, affects many users, so dare not try to remove FirebasePerformance.

Thank you.

Also, if this is configured(pod 'Firebase/Core', '~> 6.7.0'), will all the dependent Pods roll back to 6.7.0?

Installing Fabric (1.10.2) Installing Firebase (6.7.0) Installing FirebaseABTesting (3.1.1) Installing FirebaseAnalytics (6.1.1) Installing FirebaseAnalyticsInterop (1.4.0) Installing FirebaseAuth (6.2.3) Installing FirebaseAuthInterop (1.0.0) Installing FirebaseCore (6.2.1) Installing FirebaseCoreDiagnostics (1.0.1) Installing FirebaseCoreDiagnosticsInterop (1.0.0) Installing FirebaseDatabase (6.1.0) Installing FirebaseFirestore (1.4.5) Installing FirebaseInstanceID (4.2.5) Installing FirebaseMessaging (4.1.4) Installing FirebasePerformance (3.1.2) Installing FirebaseRemoteConfig (4.3.0) Installing FirebaseStorage (3.4.1) Installing FirebaseUI (8.0.4) Installing Flurry-iOS-SDK (9.3.1) Installing GTMSessionFetcher (1.2.2) Installing Google-Mobile-Ads-SDK (7.49.0) Installing GoogleAppMeasurement (6.1.1) Installing GoogleDataTransport (1.2.0) Installing GoogleDataTransportCCTSupport (1.0.4) Installing GoogleMobileAdsMediationAppLovin (6.8.0.0) Installing GoogleMobileAdsMediationFacebook (5.5.0.0) Installing GoogleMobileAdsMediationInMobi (7.3.2.0) Installing GoogleMobileAdsMediationMoPub (5.7.1.0) Installing GoogleSignIn (4.4.0) Installing GoogleToolboxForMac (2.2.1) Installing GoogleUtilities (6.2.5)

Thank you again.

neilmorton commented 5 years ago

@neilmorton OK Thank you.

You are welcome @fangyuxi

neilmorton commented 5 years ago

I believe that the backtrace shown would only come from FirebasePerformance. Would you confirm if removing FirebasePerformance makes the crash stop occurring?

@paulb777 Unfortunately I am in the same position as @fangyuxi. I had issues after moving up past 6.5.0 previously in that I was seeing a raft of GDTUploadCoordinator.m crashes. At that point there was a comment from yourself that suggested reverting to 6.5.0 https://github.com/firebase/firebase-ios-sdk/issues/3547#issuecomment-520151994.

I had just made the decision to lift that version hold with this latest release to now experience this new issue across 4 apps with the latest builds ready for iOS 13.

I don't really want to risk just removing FirebasePerformance in case there is still an issue.

Rather I have, as mentioned above, locked them all back to 6.5.0. In the meantime I shall consider the options!

neilmorton commented 5 years ago

Also, if this is configured(pod 'Firebase/Core', '~> 6.7.0'), will all the dependent Pods roll back to 6.7.0?

@fangyuxi If you run pod update after making the change in the Podfile, then it should manage the dependencies, yes.

paulb777 commented 5 years ago

If you run pod install, versions of existing pods won't necessarily change.

if you run pod update, versions will update to the latest unless there are version specifications in the Podfile.

pod 'Firebase/Core', '~> 6.7.0' indicates to use the latest Firebase pod at version 6.7.*. The Firebase pod specifies that its dependencies can do patch updates.

Thus if you do a pod update with pod 'Firebase/Core', '~> 6.7.0' you will get `FirebasePerformance 3.1.4 even though 6.7.0 released with 3.1.3.

@fangyuxi It looks like you still have 3.1.2. Please confirm the issue is still occurring with 3.1.4.

fangyuxi commented 5 years ago

Hi @paulb777

I have obtained the details of this app build binary. Hope to help.

This is the details of the App that has Crash.

-Xcode Version 10.2.1 
-Base SDK iOS 12.2
-Crash iOS Version iOS9, iOS10 only.

The pod install info.

Installing AFNetworking (3.2.1)
Installing BoringSSL-GRPC (0.0.3)
Installing CYLTabBarController (1.28.3)
Installing Crashlytics (3.14.0)
Installing DeviceUtil (5.1.0)
Installing FBAudienceNetwork (5.5.0)
Installing FBSDKCoreKit (5.5.0)
Installing FBSDKLoginKit (5.5.0)
Installing Fabric (1.10.2)
Installing Firebase (6.8.1)
Installing FirebaseABTesting (3.1.1)
Installing FirebaseAnalytics (6.1.1)
Installing FirebaseAnalyticsInterop (1.4.0)
Installing FirebaseAuth (6.2.3)
Installing FirebaseAuthInterop (1.0.0)
Installing FirebaseCore (6.2.3)
Installing FirebaseCoreDiagnostics (1.0.1)
Installing FirebaseCoreDiagnosticsInterop (1.0.0)
Installing FirebaseDatabase (6.1.0)
Installing FirebaseFirestore (1.5.0)
Installing FirebaseInstanceID (4.2.5)
Installing FirebaseMessaging (4.1.4)
Installing FirebasePerformance (3.1.4)
Installing FirebaseRemoteConfig (4.4.0)
Installing FirebaseStorage (3.4.1)
Installing FirebaseUI (8.0.4)
Installing GTMSessionFetcher (1.2.2)
Installing Google-Mobile-Ads-SDK (7.49.0)
Installing GoogleAppMeasurement (6.1.1)
Installing GoogleDataTransport (1.2.0)
Installing GoogleDataTransportCCTSupport (1.0.3)
Installing GoogleMobileAdsMediationFacebook (5.5.0.0)
Installing GoogleSignIn (4.4.0)
Installing GoogleToolboxForMac (2.2.1)
Installing GoogleUtilities (6.2.5)
Installing IQKeyboardManager (6.4.2)
Installing KVOController (1.2.0)
Installing LEEAlert (1.2.8)
Installing MJRefresh (3.2.0)
Installing MOBFoundation (3.2.5)
Installing Masonry (1.1.0)
Installing NMEasyTipView (1.2)
Installing Protobuf (3.9.0)
Installing RTRootNavigationController (0.7.1)
Installing Reachability (3.2)
Installing ReactiveCocoa (2.5)
Installing SDWebImage (5.1.1)
Installing SJBaseVideoPlayer (2.7.1)
Installing SJUIKit (0.0.0.35)
Installing SVProgressHUD (2.2.5)
Installing TOWebViewController (2.2.8)
Installing TTGTagCollectionView (1.11.1)
Installing YYCache (1.0.4)
Installing YYCategories (1.0.4)
Installing YYModel (1.0.4)
Installing gRPC-C++ (0.0.9)
Installing gRPC-Core (1.21.0)
Installing leveldb-library (1.22)
Installing lottie-ios (2.5.3)
Installing mob_sharesdk (4.3.2)
Installing nanopb (0.3.901)
Installing youtube-ios-player-helper (0.1.6)
bill350 commented 5 years ago

Same issue here :'(

iOS 10 only, Firebase dependencies:

pod 'Firebase/Core', '= 6.8.1'
pod 'Firebase/Analytics', '= 6.8.1'
pod 'Firebase/Performance', '= 6.8.1'

image

neilmorton commented 5 years ago

@bill350 Is your lowest platform supported iOS 10?

bill350 commented 5 years ago

@bill350 Is your lowest platform supported iOS 10?

Yes, iOS 10 -> iOS 13

paulb777 commented 5 years ago

Thanks for the additional data about iOS versions.

It seems that this is an issue for iOS 9 and iOS 10. Maybe also iOS 8?

neilmorton commented 5 years ago

My lowest supported build is iOS 9, and iOS 9 and 10 are affected for me. As you say, it could be for 8 too, but I can’t say, sorry.

patrickmarshall commented 5 years ago

Hello, We are also got same issue here. We haven't change firebase version since 3 months ago and the problem just start occurred since September 13th. Is it possible that the problem is from BE side?

pod 'Firebase/Core', '= 6.2.0'
pod 'Firebase/Analytics', '= 6.2.0'
pod 'Firebase/Performance', '= 6.2.0'

My lowest platform support is iOS 10.

@paulb777

andrew-muzz commented 5 years ago

Hello, Same issue here but ours is also impacting iOS 11 and 12. Having said that it's massively skewed towards iOS 10 (67%), not sure about iOS 9.x (we only support 10.2 and above). Looking at the device range affected it's 70% iPhone 5 series. These are always aligned so hard to tell if it's the device or the OS making it more likely to happen.

It only started occurring for us when we released custom tracing for the first time on 14th September. It hasn't happened for any other versions, this would seem to indicate something wrong with custom performance tracing. The following are the Firebase versions we're using:

    pod 'Firebase/Analytics', '~> 6.2.0'
    pod 'Firebase/Core', '~> 6.2.0'
    pod 'Firebase/Performance', '~> 6.2.0'
    pod 'Firebase/RemoteConfig', '~> 6.2.0'

We're going to remove custom tracing until we can figure out what this issue is.

paulb777 commented 5 years ago

Internally tracked at b/141097962

fangyuxi commented 5 years ago

Hi @patrickmarshall

Can you share your Podfile and Podfile.lock?

Strate commented 5 years ago

Maybe related. More crashes started with our new release, ios 10 & ios 9 only:

Crashed: com.google.firebase.firestore
0  chatium                        0x3574e0 GPBCodedInputStreamReadDouble + 88 (GPBUtilities_PackagePrivate.h:88)
1  chatium                        0x3574d9 GPBCodedInputStreamReadDouble + 103 (GPBCodedInputStream.m:103)
2  chatium                        0x382415 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2143 (GPBMessage.m:2143)
3  chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
4  chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
5  chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
6  chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
7  chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
8  chatium                        0x3828c3 MergeRepeatedNotPackedFieldFromCodedInputStream + 2294 (GPBMessage.m:2294)
9  chatium                        0x3823af -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2393 (GPBMessage.m:2393)
10 chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
11 chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
12 chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
13 chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
14 chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
15 chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
16 chatium                        0x357eb5 -[GPBCodedInputStream readMessage:extensionRegistry:] + 296 (GPBCodedInputStream.m:296)
17 chatium                        0x382593 -[GPBMessage mergeFromCodedInputStream:extensionRegistry:] + 2181 (GPBMessage.m:2181)
18 chatium                        0x381a8b -[GPBMessage mergeFromData:extensionRegistry:] + 1928 (GPBMessage.m:1928)
19 chatium                        0x37f199 -[GPBMessage initWithData:extensionRegistry:error:] + 868 (GPBMessage.m:868)
20 chatium                        0x381b5f +[GPBMessage parseFromData:extensionRegistry:error:] + 1957 (GPBMessage.m:1957)
21 chatium                        0x381b29 +[GPBMessage parseFromData:error:] + 1951 (GPBMessage.m:1951)
22 chatium                        0x2a7005 firebase::firestore::local::LevelDbQueryCache::DecodeTarget(absl::string_view) + 374 (leveldb_query_cache.mm:374)
23 chatium                        0x2a6bfd firebase::firestore::local::LevelDbQueryCache::GetTarget(FSTQuery*) + 164 (leveldb_query_cache.mm:164)
24 chatium                        0x251543 -[FSTLocalStore allocateQuery:] + 436 (FSTLocalStore.mm:436)
25 chatium                        0x27dd97 -[FSTSyncEngine listenToQuery:] + 221 (FSTSyncEngine.mm:221)
26 chatium                        0x2304c7 -[FSTEventManager addListener:] + 123 (FSTEventManager.mm:123)
27 chatium                        0x23d7b5 std::__1::__function::__func<-[FSTFirestoreClient listenToQuery:options:listener:]::$_8, std::__1::allocator<-[FSTFirestoreClient listenToQuery:options:listener:]::$_8>, void ()>::operator()() + 4517 (memory:4517)
28 chatium                        0x1f4dd1 firebase::firestore::util::AsyncQueue::ExecuteBlocking(std::__1::function<void ()> const&) + 1913 (functional:1913)
29 chatium                        0x20b189 firebase::firestore::util::internal::DispatchAsync(NSObject<OS_dispatch_queue>*, std::__1::function<void ()>&&)::$_0::__invoke(void*) + 1862 (functional:1862)
30 libdispatch.dylib              0x1da65ec5 _dispatch_queue_serial_drain + 840
31 libdispatch.dylib              0x1da5c379 _dispatch_queue_invoke + 566
32 libdispatch.dylib              0x1da6635d _dispatch_queue_override_invoke + 286
33 libdispatch.dylib              0x1da67a91 _dispatch_root_queue_drain + 378
34 libdispatch.dylib              0x1da678b7 _dispatch_worker_thread3 + 106
35 libsystem_pthread.dylib        0x1dc0e937 _pthread_wqthread + 1168
36 libsystem_pthread.dylib        0x1dc0e48c start_wqthread + 8
tomdwipo commented 5 years ago

Hi I have same issues with this , and its crash only for iOS 10 iPhone 5 @paulb777

visumickey commented 5 years ago

@Strate That crash messaged by you does not seem to be related to the current issue. Thanks for bring this to attention though. Can you create a separate issue to track that thread?

The recent changes to Firebase Performance SDK is not related to the stack trace shown. Seem to be a dependency issue. I will keep the group posted on the findings. We are working to make sure we crack this out soon.

visumickey commented 5 years ago

Has anyone been able to reproduce this issue locally? Curious to know if there are any log messages that happened around the crashing time?

fangyuxi commented 5 years ago

@visumickey

I have rolled back to version 6.7.0, but this Crash still appears. Below is the details.

WechatIMG3 WechatIMG4 WechatIMG5

morganchen12 commented 5 years ago

Googlers-only: Related to go/phenotype-deadlock

Strate commented 5 years ago

@visumickey I see same frames on the right side of stacktrace, but okay

ChristianVinterly commented 5 years ago

Same issue here on iOS 10 (lowest supported). Xcode 11 GM.

ashokbhakharios commented 5 years ago

Same issue here but also impacting iOS 11 and 12 users.

Firebase SDK- '6.7.0'

ChristianVinterly commented 5 years ago

Screenshot 2019-09-17 at 10 06 26

ChristianVinterly commented 5 years ago
Using Firebase (6.7.0)
Using FirebaseABTesting (3.1.0)
Using FirebaseAnalytics (6.1.1)
Using FirebaseAnalyticsInterop (1.4.0)
Using FirebaseAuth (6.2.3)
Using FirebaseAuthInterop (1.0.0)
Using FirebaseCore (6.2.1)
Using FirebaseCoreDiagnostics (1.0.1)
Using FirebaseCoreDiagnosticsInterop (1.0.0)
Using FirebaseFirestore (1.4.5)
Using FirebaseInstanceID (4.2.3)
Using FirebasePerformance (3.1.2)
Using FirebaseRemoteConfig (4.3.0)
Using FirebaseStorage (3.4.0)
ChristianVinterly commented 5 years ago

If this crash is suddenly happening on versions 6.2.0 - 6.8.1, on Xcode 10 and 11 GM, and for people that haven't changed firebase version for 3 months, then it sounds like a BE issue like @patrickmarshall suggests?

neilmorton commented 5 years ago

Looking at the results from my updates to lock back to pod 'Firebase/Core', '~> 6.5.0' as mentioned early in this thread (which only went live last night to 3 apps), I can see that (in 1 app at least), the issue is still there now I reverted to the previous version.

Further, I now see that I have a previous build that was updated around 1 month ago has now got 1 single instance of this issue that is reporting as Sep 08 2019 08:06 (UTC) (iPhone 4s iOS 9.3.5).

As @ChristianVinterly & @patrickmarshall suggest, is this a backend change that has caused this?

All crashes I am seeing have been limited to iOS 9 / 10.

ashokbhakharios commented 5 years ago

Looks like most of the crashes are on jailbroken devices though crashlytics dashboard shows 0% jailbroken devices but while checking individual crash details, All devices are shown jailbroken devices.

Screenshot 2019-09-17 at 4 13 04 PM Screenshot 2019-09-17 at 4 12 26 PM
neilmorton commented 5 years ago

I just looked at my stats and, unlike @ashokbhakharios mine are not showing as Jailbroken (either at the dashboard or individually). All are showing Jailbroken: No. So I guess that may not be linked.

ChristianVinterly commented 5 years ago

Mine are also not Jailbroken

Strate commented 5 years ago

@ChristianVinterly is your crashes caused by updating pod versions? Or it just begin crash without your actions?

bill350 commented 5 years ago

To add some information:

As suggested in my previous comment, it happens only on iOS 10 (min iOS 10 to iOS 13) and our last app version (1.6) :

image

We update Firebase regularly and we upgrade Firebase Core, Analytics and Performance from 6.7.0 to 6.9.1.

App shipped with Xcode 11 GM (not the GM 2).

ChristianVinterly commented 5 years ago

In our app, the crashes appeared yesterday after we released an update to TestFlight from Xcode 11 GM. The update did not change the Firebase SDKs, and the crash has not appeared on other versions of the app.

paulb777 commented 5 years ago

Wondering if this is a build tools issue - stemming from building with Xcode 11 instead of Xcode 10. Has anyone seen the issue with an Xcode 10 build?

ChristianVinterly commented 5 years ago

I think the original post used Xcode Version 10.2.1.

neilmorton commented 5 years ago

My latest builds are with Xcode 11 Seed. But the one I have seen spring up from a build created 1 month ago was not the latest, so was 10.x