Unreleased Resource: Database

firebase / firebase-ios-sdk

Firebase SDK for Apple App Development

https://firebase.google.com

Apache License 2.0

5.67k stars 1.49k forks source link

Unreleased Resource: Database #4552

Closed gopalchinnadurai closed 4 years ago

gopalchinnadurai commented 4 years ago

We have used FirebaseRemoteConfig 4.4.0 as per our need. Some VAPT points are mentioned in below picture. Kindly help us asap.

Issue Summary:

The function insertMainTableWithValues:fromSource:() in RCNConfigDBManager.m sometimes fails to release a database resource allocated by prepareSQL:() on line 427.The program can potentially fail to release a database resource.

Issue Screenshot:

google-oss-bot commented 4 years ago

I found a few problems with this issue:

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
This issue does not seem to follow the issue template. Make sure you provide all the required information.

morganchen12 commented 4 years ago

Looks like the line it's referring to is this early exit, which only happens if statement fails to materialize. Closing this as a non-issue since the statement cannot be released if it is nil.

If you are able to profile this section of code and share an Instruments trace demonstrating a memory leak, please comment here and we'll re-open the issue.