firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.55k stars 1.45k forks source link

157240716: Question/FR: Firebase Dynamic Links "socialmeta.page.link" #5333

Closed krisanthony closed 1 year ago

krisanthony commented 4 years ago

[READ] Guidelines

Feature proposal

When sharing a firebase dynamic link to slack, "socialmeta.page.link" and the firebase logo is visible in the link preview. Is it possible to customize or remove this?

image

Adding social meta params to link builder like so, then using the shorten to produce final url that is shared:

linkBuilder.socialMetaTagParameters = DynamicLinkSocialMetaTagParameters()
linkBuilder.socialMetaTagParameters?.title = title
linkBuilder.socialMetaTagParameters?.imageURL = imageUrl
google-oss-bot commented 4 years ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

morganchen12 commented 4 years ago

iirc it's supposed to display your app icon, though I'm not sure where this gets specified. @dmandar can you clarify?

I'll update the docs here once we get an answer.

dmandar commented 4 years ago

@maxzhouous

krisanthony commented 4 years ago

@dmandar looks like you may have meant @maxzhouus ?

emanuel-lundman commented 4 years ago

no updates on this? and no one has a solution/workaround?

diegoveloper commented 4 years ago

Any news about this issue? :/

eldhosembabu commented 4 years ago

Seems like a feature request. Will pass the internal bug (b/157240716)to product team to prioritize.

eldhosembabu commented 4 years ago

Also could you please share a sample FDL link for us to check where you have used the social meta tag parameters

joyt commented 3 years ago

@eldhosembabu Here's an example: https://par.tf/5wa4 (see below screenshot of the preview looks like on Slack) - note that there is no iOS or Android app to deep link into here, it's just used as a short link to a web page.

As you can see, the social meta tags with title, description, & image are set but unfortunately also the Firebase logo and "socialmeta.page.link" text. It would be great if there were a way to customize whatever meta tags are being auto-generated here. image

voduku commented 3 years ago

@morganchen12 any follow up on this issue? Thanks

campey commented 3 years ago

This also occurs from me when creating links from the firebase console. [https://console.firebase.google.com/project/[project-name]/durablelinks/links/]

Found this thread when looking up the issue, so thought to share to perhaps help in resolution.

oggam commented 3 years ago

Same issue on my side, any updates?

tallneil commented 3 years ago

+1

vikjovanov commented 3 years ago

+1

deepak786 commented 3 years ago

I also have a similar issue. The issue is not only from the Firebase Android or iOS SDK. This issue is actually with all the Firebase dynamic links and Slack.

if you are having the domain from .page.link then it shows that domain but if you have a custom domain then it shows the socialmeta.page.link.

Screen Shot 2020-11-30 at 1 50 10 PM Screen Shot 2020-11-30 at 1 51 01 PM
tzvc commented 3 years ago

Any updates on this ? Having the same issue ? (when link generated on Android as well)

tomasz-ludek commented 3 years ago

Any update? (the same issue here, for the custom domain)

voduku commented 3 years ago

Hi, I found out that this happens because whenever you put in socialMetaData, firebase will generate a new html for you which is why it is should a diff icon and url. If you wants to fix this, exclude socialMetadata when create your dynamic link and add the metadata tag or handle it via dynamic link sdk in your actual website

@deepak786 @theochampion @tomasz-ludek

luanccp commented 3 years ago

Any news about how to update the icon?

GlebMaltsev commented 3 years ago

Any ETA when this will be fixed?

echo3Dco commented 2 years ago

Any update on the icon fix?

caoer commented 2 years ago

same ask here

MGGranny commented 2 years ago

Any updates? This issue makes the link look unfinished, because it can't be branded completely.

alon-grinshpoon commented 2 years ago

Same ask here! Any update on this?

paulb777 commented 2 years ago

@eldhosembabu Would you take a look?

d3xt3r2909 commented 2 years ago

Same thing, also it should be clear that this is not platform-related its same thing for android SDK

naudej commented 2 years ago

+1

courtneypresto commented 2 years ago

Also following this -- same issue for me. Any update?

izakharov commented 2 years ago

Any updates on socialmeta.page.link for custom domains? still getting it in 2022 🥹

Tom3652 commented 2 years ago

+1

rizafran commented 2 years ago

Hey everyone, sorry for the late revert. We'd like to confirm if the issue is happening on Slack only?

Tom3652 commented 2 years ago

I have tried iMessage, Discord, Whatsapp and slack and it's happening on Slack only for these social networks. Edit : I have also tried Messenger and LinkedIn it works fine.

cvlos commented 2 years ago

Hello everyone 👋

I looked into this and I believe the issue is on Slack side. Specifically Slack not respecting <meta property="og:url" as mentioned on the Ope Graph Protocol. I have followed up with Slack regarding this and they are looking into it. Will keep this chat updated it with any progress.

Sorry for the inconvenience.

spinapplications commented 1 year ago

I'm seeing this issue in Android's Messages app too, i.e. socialmeta.page.link replacing the domain name.

cvlos commented 1 year ago

@spinapplications thanks for your input. Could you share an FDL link which could reproduce this issue?

Thanks

spinapplications commented 1 year ago

@cavalos0086 Thank you for looking into this.

Here is an example link: https://whenavailable.com/event/zFfVT2etsoXqoTuV6

And here is how it appears in the Messages app on my Android: Screenshot_20221014-160216

spinapplications commented 1 year ago

@cavalos0086 any thoughts?

cvlos commented 1 year ago

@spinapplications sorry for the late reply. I was able to reproduce the issue yesterday. I will take a look today and follow up with updates.

cvlos commented 1 year ago

@spinapplications Have you notice if this has worked correctly in the pass?

spinapplications commented 1 year ago

@cavalos0086 No, I have not seen this work in the past. When using the socialMetaTag object in building the dynamic link the message always shows socialmeta.page.link, instead of the domain.

cvlos commented 1 year ago

@spinapplications After checking, the issue seems to be on the Messaging app. I have created a bug for it but no ETA on when it would be fixed. I will update this chat whenever I get any updates.

spinapplications commented 1 year ago

@cavalos0086 Thanks for the update.

michelleyin96 commented 1 year ago

Any update here? @cavalos0086

cvlos commented 1 year ago

@michelleyin96 Sorry no new updates on this. Both teams have been notified and there seems to be so misalignment on the response as I commented before. https://github.com/firebase/firebase-ios-sdk/issues/5333#issuecomment-1205868785

I will add any new updates here.

aditya-arre commented 1 year ago

Any update on this issue?

gemyago commented 1 year ago

This is still happening, any plans to fix it?

nijilrajkr commented 1 year ago

Any update on this ??

DamilolaDami commented 1 year ago

wow no fix yet I still get this issue where sometimes it displays and sometimes it does not

paulb777 commented 1 year ago

Now that Firebase DynamicLinks is planned to shut down, closing its feature requests.