firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.56k stars 1.45k forks source link

Carthage update pulls in incompatible versions of FirebaseAnalyticsBinary and FirebaseCrashlyticsBinary #6037

Closed JuliusBahr closed 4 years ago

JuliusBahr commented 4 years ago

[REQUIRED] Step 1: Describe your environment

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

In your Cartfile add: binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseCrashlyticsBinary.json"

Call carthage update --platform iOS

What happened? How can we make the problem occur? The downloaded FirebaseAnalyticsBinary and FirebaseCrashlyticsBinary are incompatible with one another and lead to linker errors.

Workaround

Set an explicit version of the dependency. I used: binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" ~> 6.9 binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseCrashlyticsBinary.json" ~> 6.27

ryanwilson commented 4 years ago

Hi @JuliusBahr - sorry for the issues you're seeing. Can you please share what the linker errors are so we can better understand the issue at hand? Thanks!

JuliusBahr commented 4 years ago

@ryanwilson I'm sorry I don't have logs anymore. The linker issue was around PromisesObjC.framework. But not the signing issue seen with iOS 13.3.x. I updated from a pretty old version of Fabric/Crashlytics to the FirebaseCrashlytics. When I updated FirebaseAnalytics and FirebaseCrashlytics PromisesObjC was not updated. That is where I ran into linker issues. This was only resolved when I explicitly set the versions in Carthage to the latest versions for both FirebaseAnalytics and FirebaseCrashlytics. Without setting versions I got into a state were FirebaseCrashlytics and FirebaseAnalytics did not create a new version of PromisesObjC.

JuliusBahr commented 4 years ago

The issue should be readily reproducible.

paulb777 commented 4 years ago

This isn't obviously reproducible. I suspect something about the environment was stale or corrupt. We'll likely need a repro to make progress.

google-oss-bot commented 4 years ago

Hey @JuliusBahr. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

google-oss-bot commented 4 years ago

Since there haven't been any recent updates here, I am going to close this issue.

@JuliusBahr if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.