firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.67k stars 1.49k forks source link

Firestore Carthage installation is missing gRPC-C++ in 8.0.0 #8112

Closed paulb777 closed 3 years ago

paulb777 commented 3 years ago

Opened to track issue raised at https://github.com/firebase/firebase-ios-sdk/issues/7576#issuecomment-843774872

paulb777 commented 3 years ago

This looks like a Carthage issue. I reported at https://github.com/Carthage/Carthage/issues/3185.

In the meantime, you can get the missing gRPC-C++.xcframework by manually downloading https://dl.google.com/dl/firebase/ios/carthage/8.0.0/FirebaseFirestore-6c7035fccbea27c0.zip in the browser and unzipping

icedice commented 3 years ago

This looks like a Carthage issue. I reported at Carthage/Carthage#3185.

In the meantime, you can get the missing gRPC-C++.xcframework by manually downloading https://dl.google.com/dl/firebase/ios/carthage/8.0.0/FirebaseFirestore-6c7035fccbea27c0.zip in the browser and unzipping

While this will work for local builds it's not going to work on our CI, but I could of cause setup a custom step to download and extract the file...

paulb777 commented 3 years ago

Thanks to @elliottwilliams (in Carthage/Carthage#3185) for isolating this to an issue with the Firebase ZipBuilder in how it constructs xcframeworks for Carthage.

I'lll investigate a fix and follow up here.

paulb777 commented 3 years ago

This issue and fix also applies to In App Messaging since it also has Resources. See https://github.com/Carthage/Carthage/issues/3185#issuecomment-859902901.