firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.51k stars 1.44k forks source link

Is `gRPCCertificates-Cpp.bundle` necessary? #9184

Closed paulb777 closed 3 months ago

paulb777 commented 2 years ago

Discussed in https://github.com/firebase/firebase-ios-sdk/discussions/9183

Originally posted by **uhooi** January 7, 2022 `Firebase.zip` contains `Firebase/FirebaseFirestore/Resources/gRPCCertificates-Cpp.bundle`. https://github.com/firebase/firebase-ios-sdk/releases/tag/v8.10.0 But, I think it is no longer needed since `6.13.0`. https://firebase.google.com/support/release-notes/ios#cloud-firestore_35 Why is `gRPCCertificates-Cpp.bundle` still included in the release? If it is not needed, please remove it as it is confusing. --- - Firebase SDK version: 8.10.0
paulb777 commented 2 years ago

gRPC continues to include gRPCCertificates-Cpp.bundle even though Firestore no longer needs it, so our zip builder tooling includes it when creating the distribution.

I'll create this issue to add a special case to the zip builder to prevent resource creation for Firestore.

In the meantime, it's safe to disregard gRPCCertificates-Cpp.bundle.

uhooi commented 2 years ago

Thanks for the quick answer! I ignore the gRPCCertificates-Cpp.bundle.