firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.67k stars 1.49k forks source link

FirebaseAppDelegateProxyEnabled breaks Facebook Swift login on Facebook SDK 4.42 #924

Closed vinayakpal closed 5 years ago

vinayakpal commented 6 years ago

Im working on an iOS app where I've provide 2 option for login into the app for user( Google & Facebook) by using Firebase SDK. Now I successfully integrate both login in my app which work perfectly in iOS-11 based app. But when I tried to login from iOS-10 device it never login from both Facebook as well as google. please help I'm suffering from this issue for very long.

morganchen12 commented 6 years ago

There's not enough information in this issue to debug. Please fill out the issue template and include the version of Firebase Auth, the code you're using to integrate Firebase, and any errors in console, then re-open this issue.

vinayakpal commented 6 years ago

Currently I'm using Below mentioned version firebase pods in my project: Using Firebase (4.10.1) Using FirebaseABTesting (1.0.0) Using FirebaseAnalytics (4.1.0) Using FirebaseAuth (4.4.4) Using FirebaseCore (4.0.17) Using FirebaseInstanceID (2.0.9) Using FirebaseRemoteConfig (2.1.2)

google_signin.txt

Please check the above mention link where code file attached. I simply follows the firebase login step but it hasn't responding

vinayakpal commented 6 years ago

Kindly reopen this issue as it not has been solved

vinayakpal commented 6 years ago

is there any progress to solve this issue. please help urgently

baolocdo commented 6 years ago

Can you try using the flag FirebaseAppDelegateProxyEnabled=NO in the Info.plist and see if it solves the problem (Please follow the instruction in FIRAnalytics+AppDelegate.h if you decide to do so). If it is still not working, can you try unlink one of Analytics or Auth from your app? We would like to determine which Firebase SDK is causing the issue. Thanks

morganchen12 commented 6 years ago

@vinayakpal there are a number of issues with your implementation, including issues not specifically related to Firebase.

Please move your question to StackOverflow and make sure to include any relevant error messages when running your project.

vinayakpal commented 6 years ago

@morganchen12 I recently found that i forgot to enable keychain sharing in App Capability section. But later on I enable that but still no progress found in login. can you please help this regarding this keychain issue.

tapannathvani commented 6 years ago

We are facing the same issue, Just update the POD file and enabled key chain sharing also. Google sign in not coming back to the App. And it works well in iOS 11 but not in iOS 10.2.1. Any update ?

pepasflo commented 5 years ago

FWIW we appear to have just run into this issue when upgrading our cocoapods.

We had been using Facebook iOS SDK 4.34, then upgraded to 4.39 and a little bit later realized that we got hit by the "unknown error building URL" issue (https://github.com/facebook/facebook-swift-sdk/issues/298). We then upgraded to 4.42, which fixed Facebook login when using Safari, but not when using the Facebook app.

It appears that FirebaseAppDelegateProxyEnabled=NO fixed this issue.

Did something change regarding app delegate proxies between 4.34 and 4.42?

Was this swizzling-the-app-delegate-methods-by-default decision made in an effort to make things easier for developers? If so, this strikes me as a good example of what Rich Hickey was talking about with his "simple vs easy" concept: https://www.youtube.com/watch?v=rI8tNMsozo0. This swizzling has made things easier, but not simpler, which made it much more difficult for us to debug this issue (i.e., in terms of developer time it would have been much less expensive for us if swizzling weren't available and we were forced to forward the app delegate calls manually).

morganchen12 commented 5 years ago

Hey all, sorry for the slow response here. The goal of the FirebaseAppDelegateProxyEnabled flag was to allow developers to choose between easy or simple, but it's woefully missing from our docs. I'll take a look at fixing that soon.

In the meantime, is this still an issue in Firebase 6+ and Facebook SDK 5+?

google-oss-bot commented 5 years ago

Hey @vinayakpal. We need more information to resolve this issue but there hasn't been an update in 7 days. I'm marking the issue as stale and if there are no new updates in the next 3 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

google-oss-bot commented 5 years ago

Since there haven't been any recent updates here, I am going to close this issue.

@vinayakpal if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.