firebase / firebase-ios-sdk

Firebase SDK for Apple App Development
https://firebase.google.com
Apache License 2.0
5.67k stars 1.49k forks source link

Missing tvOS Analytics dependency in AnalyticsWithoutAdIdSupport subspec #9779

Closed alexzchut closed 2 years ago

alexzchut commented 2 years ago

Step 0: Are you in the right place?

[REQUIRED] Step 1: Describe your environment

[REQUIRED] Step 2: Describe the problem

Missing Analytics dependency when using AnalyticsWithoutAdIdSupport subspec for tvOS

Steps to reproduce:

When installing Firebase Analytics for tvOS, the dependent repository of FirebaseAnalytics is limited to iOS only and not installed when targeting for tvOS.

What happened? How can we make the problem occur? This could be a description, log/console output, etc.

If you have a downloadable sample project that reproduces the bug you're reporting, you will likely receive a faster response on your issue.

Relevant Code:

s.subspec 'AnalyticsWithoutAdIdSupport' do |ss| ss.ios.deployment_target = '10.0' ss.osx.deployment_target = '10.12' ss.tvos.deployment_target = '12.0' ss.ios.dependency 'FirebaseAnalytics/WithoutAdIdSupport', '~> 8.15.0' ss.dependency 'Firebase/CoreOnly' end

// TODO(you): code here to reproduce the problem
google-oss-bot commented 2 years ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

paulb777 commented 2 years ago

@alexzchut Thanks for the issue and the PR! At first glance, this looks like an oversight and a good fix.

In the interim, a workaround should be to directly add FirebaseAnalytics/WithoutAdIdSupport to the Podfile.

alexzchut commented 2 years ago

@paulb777 yes, thats what I am actually doing for now, until this will be fixed in podspec

tsunghung commented 2 years ago

@alexzchut Thanks for the issue report and the fix!

paulb777 commented 2 years ago

Note that with Firebase 9.0, we are now recommending against using the Firebase pod, since it may not be feasible to support as we move more of the implementation to Swift.

Thus, FirebaseAnalytics/WithoutAdIdSupport is now the recommended usability.

Nonetheless, there's no reason to remove support for the Firebase pod early so we'll merge this now. Thanks!