Bad Code bad documentation

firebase / firebase-js-sdk

Firebase Javascript SDK

https://firebase.google.com/docs/web/setup

Other

4.84k stars 889 forks source link

Bad Code bad documentation #1409

Closed frank-dspeed closed 5 years ago

frank-dspeed commented 5 years ago

I only want to open that issue because i am mad about this stack and code it simply don't works don't errors well and also no build documentation

i would call it a total mess up but its funny that your happy with this.

google-oss-bot commented 5 years ago

I found a few problems with this issue:

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
This issue does not seem to follow the issue template. Make sure you provide all the required information.

merlinnot commented 5 years ago

Hi, thanks for the opinion, however without any specifics it is hard to determine what is the root cause of your issues. Please try again.

Feiyang1 commented 5 years ago

Appreciate your interest in this project. I understand you are frustrated, but a rant without any detail is neither helpful for us to solve your problem, nor is it healthy for the community. We welcome any constructive feedback that help us improve the SDK. I encourage you to open a new issue with details about your experience - what problem you are trying to solve, what the experience is, how do you expect it to work, etc ...

frank-dspeed commented 5 years ago

@merlinnot @Feiyang1 https://github.com/firebase/firebase-js-sdk/issues/1363 that is the issue and https://github.com/grpc/grpc-node/issues/594 is solved with the newst version but this project is not update able so easy at all my issue is that it takes me to long to jump into this project to patch it to use the new grpc package that is node 11 compatible

Feiyang1 commented 5 years ago

Sorry for your experience. We have fixed the issue with https://github.com/firebase/firebase-js-sdk/commit/603cf63dd57daa5e53466a14f7f0a006d603bcfe I understand it took a while, but we can't fix it until gRPC fixes it. It's unfortunately but is a reality in this ecosystem that you will be broken by your dependencies or Node. That said, I think we can do a better job at updating the dependencies. We are currently investigating automating the process using tools like Renovate, so it will get better.

frank-dspeed commented 5 years ago

@Feiyang1 talk to google they should spend us some resources and i can give you some releasing code from my projects so you can automate the renovate process. and then apply https://michaljanaszek.com/blog/lerna-conventional-commits