Customize JSON stringification behavior of firestore.GeoPoint

[cola119]

[REQUIRED] Describe your environment

• Operating System version: macOS Mojave 10.14.6
• Browser version: Googe Chrome 84.0.4147.105
• Firebase SDK version: ^7.11.0
• Firebase Product: firestore (auth, database, storage, etc)

[REQUIRED] Describe the problem

When stringify GeoPoint instance, it becomes like a {_lat: 30, _long: 133}. The private fields have been exposed and so confusing. For example, in nuxtjs, the data fetched on the server-side is serialized and posted to the client-side. This variable results above and we have to access like geopoint._lat instead of geopoint.latitude.

So I propose implementing toJSON method like below:

class GeoPoint {
  // ...
  toJSON = () => {
    return {
      longitude: this._long,
      latitude: this._lat
    }
  }
}

toJSON behavior reference

What do you think about this proposal?

Steps to reproduce:

Relevant Code:

TS Playground

// TODO(you): code here to reproduce the problem

[var-const]

Thank you for the feature request. We can add a well-defined JSON representation for GeoPoint and Timestamp (though not for other classes in the API); this will be fixed in the next release after #3615 is merged.

Also, thanks a lot for a very detailed description!

[cola119]

Thanks! It's a big help.