firebase / firebase-js-sdk

Firebase Javascript SDK
https://firebase.google.com/docs/web/setup
Other
4.83k stars 891 forks source link

Popup closed by user when trying to sign in with Twitter #6910

Open Lyokone opened 1 year ago

Lyokone commented 1 year ago

Originally reported here: https://github.com/firebase/flutterfire/issues/10179

[REQUIRED] Describe your environment

[REQUIRED] Describe the problem

When sign in with Twitter, the popup is closed automatically before I can end the process with the error "closed by user".

Steps to reproduce:

Ensure that you are not signed in to twitter.com

const provider = new TwitterAuthProvider();
const auth = getAuth();
signInWithPopup(auth, provider)
  .then((result) => {
  }).catch((error) => {
// You get here
  });
jbalidiong commented 1 year ago

Hi @Lyokone, thanks for the report. I was able to reproduce the behavior. Let me check what we can do for this issue or bring someone here that can provide more context about it. I’ll update this thread if I have any information to share.

kraighamady commented 1 year ago

In addition, I seeing that the popup is fine if you are logged into twitter in another tab, but if not when presented with the popup, it shows a login button. If you don't click the button the error will not be returned, but when you click 'sign in' it will then return the error that the user closed the popup before the process completed. Please note that the sign in link will take you to the login page inside the popup and it will continue.

theone3nu commented 1 year ago

Facing the same issue. When user is already logged into twitter in another tab then sign in with twitter just works fine. But when user had logged out twitter then tried to sign in with twitter it asks for the sign in. As soon as when we click on sign in button then it is returning error Popup closed by User. This is in web app

kraighamady commented 1 year ago

Update: This issue now seems to be happening if the user is signed into a second window or not. To work around the original issue, I asked the user to log into twitter in a separate window and then come back to my app to complete the link/login. This is no longer working. @jbalidiong do you know when this might be investigated? Thanks!

jbalidiong commented 1 year ago

@kraighamady, apologies for the delay. The Auth team and I are currently investigating the issue at hand. We'll provide any update if we have any information to share.

kraighamady commented 1 year ago

@jbalidiong It seems to be working more often now (so far). I will keep an eye on it and will post more information when I see it again. I did see additional error information the last time it presented that may help.

Raviteja11122 commented 2 weeks ago

Are there any updates on this? I am facing the same issue with Microsoft login.