FR: Add generic support for firestore *.collection(...) methods.

[paulmand3l]

[REQUIRED] Describe your environment

• Operating System version: OSX 10.15.7
• Browser version: Chrome for OSX 109.0.5414.119
• Firebase SDK version: JS - 9.17.1
• Firebase Product: firestore

[REQUIRED] Describe the problem

It would be convenient to be able to use generic types when getting collection references from firestore() and as subcollections of docRefs.

Steps to reproduce:

Get a collection from firestore or a docRef.

Relevant Code:

// Currently
const usersCollection = firestore().collection('users');
// usersCollection is CollectionReference<DocumentData>

// Desired
type User = {...};
const usersCollection = firestore().collection<User>('users');
// usersCollection is type CollectionReference<User>

Same for subcollections

[ehsannas]

Thanks for the suggestion @paulmand3l . We'll add this to our feature request list and consider it based on priority against other ones.

[mikehardy]

Hey @ehsannas - this has a linked PR so could just be merged if it seems okay - curious whether that's a possibility, if so what the thinking on timeline is. We've got a related PR lodged with react-native-firebase since we do our best to maintain type fidelity over there

[ehsannas]

This is similar to https://github.com/googleapis/nodejs-firestore/issues/1792. We're working on a fix that's larger in scope than the PR proposed above. I'll provide an update once our solution is merged/released. Thank you for your patience.

[mikehardy]

I see! Thanks for the update @ehsannas - @paulmand3l I think it will pay to wait on react-native-firebase then, so we do one typing change with an adoption of the final solution vs rushing with some half-thing

[paulmand3l]

👍🏻

On Sat, Mar 25, 2023 at 6:06 AM Mike Hardy @.***> wrote:

I see! Thanks for the update @ehsannas https://github.com/ehsannas - @paulmand3l https://github.com/paulmand3l I think it will pay to wait on react-native-firebase then, so we do one typing change with an adoption of the final solution vs rushing with some half-thing

— Reply to this email directly, view it on GitHub https://github.com/firebase/firebase-js-sdk/issues/7043#issuecomment-1483819373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5LW7KRHG4FTOTIVXRIP3W53UT5ANCNFSM6AAAAAAU6TEH24 . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from my iPhone.