Open fred-boink opened 6 months ago
Looks like the same issue as https://github.com/firebase/firebase-js-sdk/issues/8013!
This keeps happening to users. This is the extent of our code. Why would the device stop sending pushes?
messaging.onBackgroundMessage((payload) => {
const {data} = payload;
const notificationTitle = data?.title;
const notificationOptions = {
data: {
link: data?.link
},
body: data?.body,
badge: './icons/icon-mono.png',
icon:
data?.senderProfileImage
};
return self.registration.showNotification(
notificationTitle,
notificationOptions
);
});
We are also having the same issue, looks like it works about 3 times on iOS and then just stops until the app is then opened and the token refreshed again.
messaging.onBackgroundMessage((payload) => {
const notificationTitle = payload.notification.title;
const notificationOptions = {
body: payload.notification.body,
icon: payload.notification.image ?? "/icon-256x256.png",
click_action: payload.data.link,
};
return self.registration.showNotification(
notificationTitle,
notificationOptions
);
});
Could this be related to this? https://dev.to/progressier/how-to-fix-ios-push-subscriptions-being-terminated-after-3-notifications-39a7
Not sure if the onBackgroundMessage message takes care of the waitUntil
Could this be related to this? https://dev.to/progressier/how-to-fix-ios-push-subscriptions-being-terminated-after-3-notifications-39a7
Not sure if the onBackgroundMessage message takes care of the waitUntil
I suspect the issue is iOS thinks this is a invisible push notifications because firebase is doing it async, but until someone actually looks into, I don't know. We are debating moving off of FCM for this reason, it just stops working after some time.
Alright that is indeed the issue, I just ran a bunch of test and I replace the onBackgroundMessage with this in my service worker:
self.addEventListener('push', function(event) {
console.log('[Service Worker] Push Received.');
const payload = event.data.json(); // Assuming the payload is sent as JSON
const notificationTitle = payload.notification.title;
const notificationOptions = {
body: payload.notification.body,
icon: payload.notification.icon,
image: payload.notification.image,
badge: payload.notification.badge,
};
event.waitUntil(
self.registration.showNotification(notificationTitle, notificationOptions)
);
});
This is working perfectly, so I just remove all trace of firebase in the service worker. All the notifications are coming in now in iOS.
I think this need to be address in the firebase codebase.
Alright that is indeed the issue, I just ran a bunch of test and I replace the onBackgroundMessage with this in my service worker:
`self.addEventListener('push', function(event) { console.log('[Service Worker] Push Received.'); const payload = event.data.json(); // Assuming the payload is sent as JSON const notificationTitle = payload.notification.title; const notificationOptions = { body: payload.notification.body, icon: payload.notification.icon, image: payload.notification.image, badge: payload.notification.badge, }; event.waitUntil( self.registration.showNotification(notificationTitle, notificationOptions) ); });
This is working perfectly, so I just remove all trace of firebase in the service worker. All the notifications are coming in now in iOS.
I think this need to be address in the firebase codebase.
How do we get their attention!
Alright that is indeed the issue, I just ran a bunch of test and I replace the onBackgroundMessage with this in my service worker:
`self.addEventListener('push', function(event) { console.log('[Service Worker] Push Received.'); const payload = event.data.json(); // Assuming the payload is sent as JSON const notificationTitle = payload.notification.title; const notificationOptions = { body: payload.notification.body, icon: payload.notification.icon, image: payload.notification.image, badge: payload.notification.badge, }; event.waitUntil( self.registration.showNotification(notificationTitle, notificationOptions) ); });
This is working perfectly, so I just remove all trace of firebase in the service worker. All the notifications are coming in now in iOS. I think this need to be address in the firebase codebase.How do we get their attention!
Yeah, seems like a big deal, since it is not working on iOS
Wow this solved my exact problem. Thank you!!
Alright that is indeed the issue, I just ran a bunch of test and I replace the onBackgroundMessage with this in my service worker:
self.addEventListener('push', function(event) { console.log('[Service Worker] Push Received.'); const payload = event.data.json(); // Assuming the payload is sent as JSON const notificationTitle = payload.notification.title; const notificationOptions = { body: payload.notification.body, icon: payload.notification.icon, image: payload.notification.image, badge: payload.notification.badge, }; event.waitUntil( self.registration.showNotification(notificationTitle, notificationOptions) ); });
This is working perfectly, so I just remove all trace of firebase in the service worker. All the notifications are coming in now in iOS.
I think this need to be address in the firebase codebase.
Not working for me. OK for Android but not in IOS.
Wow this solved my exact problem. Thank you!!
Hello. Possible to have a piece of code ?
Update: After fixing some issues with my service worker and nixing my foreground notification handlers, it seems to work more reliably with the event.waitUntil() solution.
Another Update: A notification failed to send after 44 restarts. I was able to reactivate by requesting another token (after an additional restart) but I don't know what causes it as I'm just calling FCM's getToken. I'm thinking of occasionally checking if the token changes against the one stored in local storage and replacing it when needed.
More Findings: When FCM's getToken is called, it appears to update that client's token in Firebase's Topics. It's not reactivating the old token. The old token returns UNREGISTERED. The double notification might be that the token gets subscribed twice to a Topic (one is a new subscription, and the other one is mapped from the old one?).
I also removed Firebase from the service worker. I then tested if notifications would break by restarting the iOS device over and over while also sending a notification between restarts. Eventually, a notification would fail. It is possible it triggered three silent notifications but I also noticed other PWAs on the same device would not be able to confirm the subscription status either.
I don't believe this issue is specific to one PWA's implementation and it's just a bug with Safari. Or somehow another PWA's implementation is causing the others to fail on the same device.
I also noticed that requesting a new messaging token seems to "reactivate" the old one. If you subscribe with this new token, and send a notification to the topic, the iOS device will get two separate notifications.
Edit: I removed the other PWAs, and after a dozen restarts, the notifications still work as expected. I'm still doubtful, so I'll keep trying to reproduce it.
Edit 2: It eventually ended up failing twice afterwards.
@rchan41 Hi! Sorry just to be clear did you get your PWA to send Push notifications to IOS ? Did it work?
@rchan41 Hi! Sorry just to be clear did you get your PWA to send Push notifications to IOS ? Did it work?
Yes, I didn't have issues sending push notifications to iOS. The issue I described with notifications after restarting the iOS device. However, these issues might be unrelated to the topic's issue.
I can confirm that this is indeed because of silent notifications, when you have an onMessage
handler for the foreground to handle the notification yourself (for example showing a toast in your app) and the app gets a push notification, Safari's console logs:
Push event ended without showing any notification may trigger removal of the push subscription.
On the third silent notification, Safari disables push notifications.
Having the app in the background, so that onBackgroundMessage
is being triggered, does not cause this issue.
@DarthGigi This is working properly? What version of firebase are you using? I am still getting unregistering even when using simple code like:
self.addEventListener('push', function(event) {
console.log('[Service Worker] Push Received.');
const payload = event.data.json(); // Assuming the payload is sent as JSON
const notificationTitle = payload.notification.title;
const notificationOptions = {
body: payload.notification.body,
icon: payload.notification.icon,
image: payload.notification.image,
badge: payload.notification.badge,
};
event.waitUntil(
self.registration.showNotification(notificationTitle, notificationOptions)
);
});
`
@fred-boink this is the latest iteration of things on one of the projects that I'm working on. I wasn't the original developer so it's been quite a journey trying to troubleshoot. The current iteration of the firebase service worker is still leading to reports of notifications stopping after a while. Don't know what the secret sauce is.
firebase-sw.js
self.addEventListener('notificationclick', function(event) {
event.notification.close();
if (event.notification && event.notification.data && event.notification.data.notification) {
const url = event.notification.data.notification.click_action;
event.waitUntil(
self.clients.matchAll({type: 'window'}).then( windowClients => {
for (var i = 0; i < windowClients.length; i++) {
var client = windowClients[i];
if (client.url === url && 'focus' in client) {
return client.focus();
}
}
if (self.clients.openWindow) {
console.log("open window")
return self.clients.openWindow(url);
}
})
)
}
}, false);
importScripts('https://www.gstatic.com/firebasejs/9.2.0/firebase-app-compat.js');
importScripts('https://www.gstatic.com/firebasejs/9.2.0/firebase-messaging-compat.js');
const firebaseConfig = {
apiKey: "...",
authDomain: "...",
databaseURL: "...",
projectId: "...",
storageBucket: "...",
messagingSenderId: "...",
appId: "...",
}
firebase.initializeApp(firebaseConfig);
const messaging = firebase.messaging();
self.addEventListener('push', function (event) {
messaging.onBackgroundMessage(async (payload) => {
const notification = JSON.parse(payload.data.notification);
const notificationOptions = {
body: notification.body,
icon: notification.icon,
data: {
notification: {
click_action: notification.click_action
}
},
};
return event.waitUntil(
self.registration.showNotification(notification.title, notificationOptions)
);
});
});
Then there's also a component with the following:
receiveMessage() {
try {
onMessage(this.messaging, (payload) => {
this.currentMessage = payload;
let message = payload.data.username + ":\n\n" + payload.data.message;
this.setNotificationBoxForm(
payload.data.a,
payload.data.b,
payload.data.c
);
this.notify = true;
setTimeout(() => {
this.notify = false;
}, 3000);
});
} catch (e) {
console.log(e);
}
},
...
created() {
this.receiveMessage();
},
@fred-boink I'm using Firebase version 10.12.2 which is the latest version at the time of writing. Safari unregistering is still an issue and I don't think we can easily fix it without firebase's help.
@DarthGigi Yes, none of my changes have worked. They need to fix this, its. a major problem. Anyway we can get their attention?
@fred-boink It is indeed a major problem, I thought this ticket would get their attention, I have no idea why it didn’t. I don’t know any other ways to get their attention other than mail them.
Greetings. We have faced the same problem for our PWA on iOS. Code works perfect for Android, Windows, Mac and other systems, except iOS. Version of iOS is 17+ for all our devices. Unfortunately, it stopped to show notifications at all. Before we at least got some, but now we can't get even a single notification for iOS (thus we can see in logs that it was successfully send to FCM). Our implementation in the SW:
importScripts("https://www.gstatic.com/firebasejs/10.0.0/firebase-app-compat.js");
importScripts("https://www.gstatic.com/firebasejs/10.0.0/firebase-messaging-compat.js");
firebase.initializeApp({
...
});
const messaging = firebase.messaging();
self.addEventListener('push', (event) => {
event.stopImmediatePropagation();
const data = event.data?.json() ?? {};
console.log('Got push notification', data);
event.waitUntil(
processNotificationData(data)
.then(payload => {
console.log('Notification:', payload);
return clients.matchAll({ includeUncontrolled: true, type: 'window' }).then((clientList) => {
return self.registration.getNotifications().then((notifications) => {
// Concatenate notifications with the same tag and show only one
for (let i = 0; i < notifications.length; i++) {
const isEqualNotEmptyTag = notifications[i].data?.tag && payload.data?.['tag'] && (notifications[i].data.tag === payload.data?.['tag']);
if (isEqualNotEmptyTag) {
payload.body = payload.data.text = notifications[i].body + '\n' + payload.body;
}
}
// Show notification
return self.registration.showNotification(payload.data?.title, payload);
});
});
})
.catch(error => {
console.error('Error processing push notification', error);
})
);
});
async function processNotificationData(payload) {
const icon = payload.data?.['icon'] || 'assets/logo.svg';
const text = payload.data?.['text'];
const title = payload.data?.['title'];
const url = payload.data?.['redirectUrl'] || '';
const options = {
tag: payload.data?.['tag'],
timestamp: Date.now(),
body: text,
icon,
data: {
...payload.data,
icon,
text,
title,
redirectUrl: url,
onActionClick: {
default: {
operation: 'focusLastFocusedOrOpen',
url
}
}
},
silent: payload?.data?.['silent'] === 'true' ?? false
};
if (!options.silent) {
options.vibrate = [200, 100, 200, 100, 200, 100, 200];
}
return options;
}
// handle notification click
self.addEventListener('notificationclick', (event) => {
console.log('notificationclick received: ', event);
event.notification.close();
// Get the URL from the notification
const url = event.notification.data?.onActionClick?.default?.url || event.notification.data?.click_action;
event.waitUntil(
...
);
});
self.addEventListener('install', (event) => {
console.log('Service Worker installing.');
event.waitUntil(self.skipWaiting());
});
self.addEventListener('activate', (event) => {
console.log('Service Worker activating.');
event.waitUntil(clients.claim().then(() => {
console.log('Service Worker clients claimed.');
}));
});
self.addEventListener('message', (event) => {
if (event.data && event.data.type === 'SKIP_WAITING') {
self.skipWaiting().then(() => {
console.log('Service Worker skipWaiting called.');
});
}
});
self.addEventListener('fetch', (event) => {
console.log('Fetching:', event.request.url);
});
Can anyone please help? Or any advices how to get them?
After some reproduction attempts, here's what I've found:
Silent Push
I have not been able to reproduce this issue. My PWA continues to receive notifications (I have sent 50+) even if I don't have event.waitUntil
in my onBackgroundMessage
handler. Any additional information from anyone experiencing this issue (@fred-boink, @DarthGigi, @gbaggaley, @graphem) would be very helpful. This could be Safari/iOS version, logs, exact reproduction steps, minimal reproduction codebase, or state of browser storage.
Device Restarts
I have been able to reproduce the issue that @rchan41 is facing, where notifications are no longer sent after a device restarts, and then they're all received once the PWA is opened again. If I replace my usage of onBackgroundMessage
with
self.addEventListener('push', () => self.registration.showNotification('test notification', {}))
, the issue goes away, and notifications continue to be received after devices restarts. Discussion on this bug should be moved to https://github.com/firebase/firebase-js-sdk/issues/8444.
Hey @fred-boink. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.
If you have more information that will help us get to the bottom of this, just add a comment!
@dlarocque Thanks for looking into it. Ill include my config. I am not sure how to reproduce but I am using NextJS. Eventually after sometime the device just loses its registration and needs to re-register. I have tried everything suggested in here but still no success. Because it happens only on device and after a day or two it is hard to capture logs.
self.addEventListener('push', function(event) {
event.stopImmediatePropagation();
const {data} = event.data.json(); // Assuming the payload is sent as JSON
const notificationTitle = data?.title;
const notificationOptions = {
data: {
link: data?.link
},
body: data?.body
badge: './icons/icon-mono.png',
icon:
data?.senderProfileImage
};
event.waitUntil(
self.registration.showNotification(notificationTitle, notificationOptions)
);
});
@dlarocque Thanks for looking into it. Ill include my config. I am not sure how to reproduce but I am using NextJS. Eventually after sometime the device just loses its registration and needs to re-register. I have tried everything suggested in here but still no success. Because it happens only on device and after a day or two it is hard to capture logs.
self.addEventListener('push', function(event) { event.stopImmediatePropagation(); const {data} = event.data.json(); // Assuming the payload is sent as JSON const notificationTitle = data?.title; const notificationOptions = { data: { link: data?.link }, body: data?.body badge: './icons/icon-mono.png', icon: data?.senderProfileImage }; event.waitUntil( self.registration.showNotification(notificationTitle, notificationOptions) ); });
Thanks for sharing that code snippet! I see you're no longer using onBackgroundMessage
. Since you're still experiencing the issue, do you believe this might be a WebKit issue? Do you know if this happens on devices with a specific Safari or iOS version? I don't experience this bug, which makes me suspect that it has been fixed on more recent WebKit versions (including the one I'm using).
@dlarocque I am using the latest release of 17.6.1. Do you have a specific version or changelog about this? Here are some reports to Apple;
@dlarocque:
This could be Safari/iOS version, logs, exact reproduction steps, minimal reproduction codebase, or state of browser storage.
I just wanna say for the record, that this issue isn't limited to iOS/iPadOS Safari but also macOS Safari (at least at the time I wrote my comments). Maybe this info can help make debugging the issue easier by using macOS Safari.
@dlarocque:
This could be Safari/iOS version, logs, exact reproduction steps, minimal reproduction codebase, or state of browser storage.
I just wanna say for the record, that this issue isn't limited to iOS/iPadOS Safari but also macOS Safari (at least at the time I wrote my comments). Maybe this info can help make debugging the issue easier by using macOS Safari.
That's very helpful to know- debugging in PWA service workers is much harder than ones on macOS 😅
If this issue exists in applications that don't use Firebase, I think we can classify this as a WebKit issue, and keep an eye out for new changes in WebKit that might fix this.
Even though I wasn't able to reproduce this myself, I'll label is as a bug and keep it open so that others can find it. If anyone believes that this is an issue with Firebase and not WebKit- please open a new issue so that it's easier to spot for the team.
If anyone has any updates about this (webkit changes, new errors, workarounds, etc..), please add a comment to this thread!
Operating System
iOS 18.4+
Browser Version
Safari
Firebase SDK Version
10.7.2
Firebase SDK Product:
Messaging
Describe your project's tooling
NextJS 13 PWA
Describe the problem
Push notifications eventually stop being received until device is re-registered. Can take a few hours and lots of messages to occur but eventually stops receiving push.
People mention this can be a cause, Silent Push can cause your device to become unregistered: https://dev.to/progressier/how-to-fix-ios-push-subscriptions-being-terminated-after-3-notifications-39a7
https://developer.apple.com/documentation/usernotifications/sending_web_push_notifications_in_web_apps_and_browsers
Possible that Firebase does not waitUntil and WebKit thinks its a invisible push?
Steps and code to reproduce issue
public/firebase-messaging-sw.js