search

firebase / firebase-js-sdk

Firebase Javascript SDK
https://firebase.google.com/docs/web/setup
Other
4.74k stars 868 forks source link

Emit a module package file into esm2017 auth webextension bundle #8191

Closed dlarocque closed 3 weeks ago

dlarocque commented 4 weeks ago

The Firebase Auth webextension bundle was previously being shipped as a CommonJS package rather than a ES module, because it did not have a module package file indicating that it was an ES module.

Fixes #8115

Aside: The web-extension entry point does not have a Node bundle, and browser bundles don't normally require a package.json file with { "type": "module" }, but certain browser testing frameworks use Node, and need working ES module resolution.

changeset-bot[bot] commented 4 weeks ago

🦋 Changeset detected

Latest commit: 084a78116c9a20a529f2b27a5097f830b23e94d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @firebase/auth | Patch | | @firebase/auth-compat | Patch | | firebase | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot commented 4 weeks ago

<!DOCTYPE html>

Size Report 1

Affected Products

No changes between base commit (62a20ff) and merge commit (4988fc7).

Test Logs

google-oss-bot commented 4 weeks ago

<!DOCTYPE html>

Size Analysis Report 1

Affected Products

No changes between base commit (62a20ff) and merge commit (4988fc7).

Test Logs