MarkDuckworth commented 3 weeks ago

Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:

Discussion

Read the contribution guidelines (CONTRIBUTING.md).
If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.

Testing

Make sure all existing tests in the repository pass after your change.
If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 0f150bcafd7bf00bf5159d13599d5328e282dd7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Size Report ¹

Affected Products

@firebase/firestore
Type Base (03069bb) Merge (63863db) Diff
browser 377 kB 377 kB +88 B (+0.0%)
esm5 362 kB 362 kB +96 B (+0.0%)
module 377 kB 377 kB +88 B (+0.0%)
react-native 377 kB 377 kB +88 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
browser	377 kB	377 kB	+88 B (+0.0%)
esm5	362 kB	362 kB	+96 B (+0.0%)
module	377 kB	377 kB	+88 B (+0.0%)
react-native	377 kB	377 kB	+88 B (+0.0%)

`bundle`

Type	Base (03069bb)	Merge (63863db)	Diff
firestore (CSI Auto Indexing Disable and Delete)	269 kB	269 kB	+73 B (+0.0%)
firestore (CSI Auto Indexing Enable)	269 kB	269 kB	+73 B (+0.0%)
firestore (Persistence)	303 kB	303 kB	+73 B (+0.0%)
firestore (Query Cursors)	241 kB	241 kB	+73 B (+0.0%)
firestore (Query)	238 kB	238 kB	+73 B (+0.0%)
firestore (Read data once)	226 kB	226 kB	+73 B (+0.0%)
firestore (Read Write w Persistence)	323 kB	323 kB	+73 B (+0.0%)
firestore (Realtime updates)	229 kB	229 kB	+73 B (+0.0%)
firestore (Transaction)	205 kB	205 kB	+73 B (+0.0%)
firestore (Write data)	205 kB	205 kB	+73 B (+0.0%)

firebase
Type Base (03069bb) Merge (63863db) Diff
firebase-compat.js 786 kB 786 kB +73 B (+0.0%)
firebase-firestore-compat.js 342 kB 342 kB +73 B (+0.0%)
firebase-firestore.js 436 kB 436 kB +88 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
firebase-compat.js	786 kB	786 kB	+73 B (+0.0%)
firebase-firestore-compat.js	342 kB	342 kB	+73 B (+0.0%)
firebase-firestore.js	436 kB	436 kB	+88 B (+0.0%)

Test Logs

Base (03069bb): https://github.com/firebase/firebase-js-sdk/actions/runs/8785540019
Merge (63863db): https://github.com/firebase/firebase-js-sdk/actions/runs/8790852496

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Size Analysis Report ¹

Affected Products

@firebase/firestore
- addDoc
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 124 kB 124 kB +72 B (+0.1%)
  size-with-ext-deps 196 kB 196 kB +73 B (+0.0%)
- deleteDoc
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 115 kB 115 kB +72 B (+0.1%)
  size-with-ext-deps 187 kB 187 kB +73 B (+0.0%)
- disableNetwork
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 103 kB 103 kB +72 B (+0.1%)
  size-with-ext-deps 175 kB 175 kB +73 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 186 kB 186 kB +72 B (+0.0%)
  size-with-ext-deps 259 kB 259 kB +73 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 222 kB 222 kB +72 B (+0.0%)
  size-with-ext-deps 295 kB 295 kB +73 B (+0.0%)
- enableNetwork
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 103 kB 103 kB +72 B (+0.1%)
  size-with-ext-deps 175 kB 175 kB +73 B (+0.0%)
- executeWrite
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 114 kB 114 kB +72 B (+0.1%)
  size-with-ext-deps 186 kB 186 kB +73 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 110 kB 110 kB +72 B (+0.1%)
  size-with-ext-deps 182 kB 182 kB +73 B (+0.0%)
- getCountFromServer
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 110 kB 110 kB +72 B (+0.1%)
  size-with-ext-deps 183 kB 183 kB +73 B (+0.0%)
- getDoc
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 144 kB 145 kB +72 B (+0.0%)
  size-with-ext-deps 217 kB 217 kB +73 B (+0.0%)
- getDocFromServer
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 145 kB 145 kB +72 B (+0.0%)
  size-with-ext-deps 217 kB 217 kB +73 B (+0.0%)
- getDocs
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 146 kB 146 kB +72 B (+0.0%)
  size-with-ext-deps 219 kB 219 kB +73 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 146 kB 146 kB +72 B (+0.0%)
  size-with-ext-deps 218 kB 218 kB +73 B (+0.0%)
- loadBundle
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 112 kB 112 kB +72 B (+0.1%)
  size-with-ext-deps 185 kB 185 kB +73 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 100 kB 100 kB +72 B (+0.1%)
  size-with-ext-deps 172 kB 172 kB +73 B (+0.0%)
- onSnapshot
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 147 kB 147 kB +72 B (+0.0%)
  size-with-ext-deps 219 kB 219 kB +73 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 136 kB 136 kB +72 B (+0.1%)
  size-with-ext-deps 208 kB 208 kB +73 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 183 kB 184 kB +72 B (+0.0%)
  size-with-ext-deps 256 kB 256 kB +73 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 219 kB 219 kB +72 B (+0.0%)
  size-with-ext-deps 292 kB 292 kB +73 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 183 kB 183 kB +72 B (+0.0%)
  size-with-ext-deps 256 kB 256 kB +73 B (+0.0%)
- runTransaction
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 124 kB 124 kB +72 B (+0.1%)
  size-with-ext-deps 196 kB 196 kB +73 B (+0.0%)
- setDoc
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 123 kB 123 kB +72 B (+0.1%)
  size-with-ext-deps 195 kB 195 kB +73 B (+0.0%)
- updateDoc
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 123 kB 123 kB +72 B (+0.1%)
  size-with-ext-deps 196 kB 196 kB +73 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 103 kB 103 kB +72 B (+0.1%)
  size-with-ext-deps 176 kB 176 kB +73 B (+0.0%)
- writeBatch
  Size
  Type Base (03069bb) Merge (63863db) Diff
  size 125 kB 125 kB +72 B (+0.1%)
  size-with-ext-deps 198 kB 198 kB +73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	124 kB	124 kB	+72 B (+0.1%)
size-with-ext-deps	196 kB	196 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	115 kB	115 kB	+72 B (+0.1%)
size-with-ext-deps	187 kB	187 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	103 kB	103 kB	+72 B (+0.1%)
size-with-ext-deps	175 kB	175 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	186 kB	186 kB	+72 B (+0.0%)
size-with-ext-deps	259 kB	259 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	222 kB	222 kB	+72 B (+0.0%)
size-with-ext-deps	295 kB	295 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	103 kB	103 kB	+72 B (+0.1%)
size-with-ext-deps	175 kB	175 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	114 kB	114 kB	+72 B (+0.1%)
size-with-ext-deps	186 kB	186 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	110 kB	110 kB	+72 B (+0.1%)
size-with-ext-deps	182 kB	182 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	110 kB	110 kB	+72 B (+0.1%)
size-with-ext-deps	183 kB	183 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	144 kB	145 kB	+72 B (+0.0%)
size-with-ext-deps	217 kB	217 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	145 kB	145 kB	+72 B (+0.0%)
size-with-ext-deps	217 kB	217 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	146 kB	146 kB	+72 B (+0.0%)
size-with-ext-deps	219 kB	219 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	146 kB	146 kB	+72 B (+0.0%)
size-with-ext-deps	218 kB	218 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	112 kB	112 kB	+72 B (+0.1%)
size-with-ext-deps	185 kB	185 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	100 kB	100 kB	+72 B (+0.1%)
size-with-ext-deps	172 kB	172 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	147 kB	147 kB	+72 B (+0.0%)
size-with-ext-deps	219 kB	219 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	136 kB	136 kB	+72 B (+0.1%)
size-with-ext-deps	208 kB	208 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	183 kB	184 kB	+72 B (+0.0%)
size-with-ext-deps	256 kB	256 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	219 kB	219 kB	+72 B (+0.0%)
size-with-ext-deps	292 kB	292 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	183 kB	183 kB	+72 B (+0.0%)
size-with-ext-deps	256 kB	256 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	124 kB	124 kB	+72 B (+0.1%)
size-with-ext-deps	196 kB	196 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	123 kB	123 kB	+72 B (+0.1%)
size-with-ext-deps	195 kB	195 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	123 kB	123 kB	+72 B (+0.1%)
size-with-ext-deps	196 kB	196 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	103 kB	103 kB	+72 B (+0.1%)
size-with-ext-deps	176 kB	176 kB	+73 B (+0.0%)

Type	Base (03069bb)	Merge (63863db)	Diff
size	125 kB	125 kB	+72 B (+0.1%)
size-with-ext-deps	198 kB	198 kB	+73 B (+0.0%)

Test Logs

Base (03069bb): https://github.com/firebase/firebase-js-sdk/actions/runs/8785540019
Merge (63863db): https://github.com/firebase/firebase-js-sdk/actions/runs/8790852496

firebase / firebase-js-sdk

Investigating additional stats events. #8196

Discussion

Testing

API Changes

⚠️ No Changeset found

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/firestore

addDoc

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromServer

getDocs

getDocsFromServer

loadBundle

memoryLocalCache

onSnapshot

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

updateDoc

waitForPendingWrites

writeBatch

Test Logs

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/firestore`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`loadBundle`

`memoryLocalCache`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`updateDoc`

`waitForPendingWrites`

`writeBatch`