Keep the context on cancel callback handler.

firebase / firebase-js-sdk

Firebase Javascript SDK

Other

4.74k stars 868 forks source link

I have an issue where there is an unhandled promise rejection throwing, but I have an error handler on this scenario, it looks something like this

const Display = function(deviceId){
  Component.call(this)
  this.bindedOnUnhandledRejection_ = this.onUnhandledRejection_.bind(this)
}

Display.prototype.addEventListeners = function(){
  window.addEventListener("unhandledrejection", this.bindedOnUnhandledRejection_)
}

Display.prototype.onUnhandledRejection_ = function(event){
  this.logger_.log({
    message: event.reason instanceof Error ? 
      event.reason.message :
      String(event.reason), 
    type: 'ERROR',
  }, {
    'reason': maybeConvertErrorToSerializableObject(event.reason),
  })
  this.paintErrors_()
}

My issue is that onUnhandledRejection is getting called from Firebase, and Firebase is removing the context from my function. So the error comes in and `this.logger` is undefined.

I'm proposing that Firebase should not be messing with my function context.

firebase / firebase-js-sdk

Keep the context on cancel callback handler. #8204

⚠️ No Changeset found