hsubox76 commented 3 weeks ago

Change so that systemInstruction param can be passed in to the model or to methods as a string, as well as a Part or Content.

Parallel GoogleAI PR: https://github.com/google-gemini/generative-ai-js/pull/113

changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 01b22311661a9025258eb92e5b770bdc9f352831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Size Report ¹

Affected Products

@firebase/vertexai
Type Base (1aadc47) Merge (392380a) Diff
browser 23.9 kB 24.4 kB +506 B (+2.1%)
main 24.5 kB 25.0 kB +506 B (+2.1%)
module 23.9 kB 24.4 kB +506 B (+2.1%)
firebase
Type Base (1aadc47) Merge (392380a) Diff
firebase-vertexai.js 18.5 kB 18.8 kB +316 B (+1.7%)

Type	Base (1aadc47)	Merge (392380a)	Diff
browser	23.9 kB	24.4 kB	+506 B (+2.1%)
main	24.5 kB	25.0 kB	+506 B (+2.1%)
module	23.9 kB	24.4 kB	+506 B (+2.1%)

Type	Base (1aadc47)	Merge (392380a)	Diff
firebase-vertexai.js	18.5 kB	18.8 kB	+316 B (+1.7%)

Test Logs

Base (1aadc47): https://github.com/firebase/firebase-js-sdk/actions/runs/8791882911
Merge (392380a): https://github.com/firebase/firebase-js-sdk/actions/runs/8854601415

google-oss-bot commented 3 weeks ago

<!DOCTYPE html>

Size Analysis Report ¹

Affected Products

`@firebase/vertexai`

`GenerativeModel`

Size

Type	Base (1aadc47)	Merge (392380a)	Diff
size	15.8 kB	16.2 kB	+318 B (+2.0%)
size-with-ext-deps	34.3 kB	34.6 kB	+318 B (+0.9%)

Dependency

Type	Base (1aadc47)	Merge (392380a)	Diff
functions	23 dependencies addHelpers aggregateResponses assignRoleToPartsAndValidateSendMessageRequest buildFetchOptions constructRequest countTokens formatBlockErrorMessage formatGenerateContentInput formatNewContent generateContent generateContentStream generateResponseSequence getClientHeaders getFunctionCalls getHeaders getResponsePromise getResponseStream getText hadBadFinishReason makeRequest processStream registerVertex validateChatHistory	24 dependencies addHelpers aggregateResponses assignRoleToPartsAndValidateSendMessageRequest buildFetchOptions constructRequest countTokens formatBlockErrorMessage formatGenerateContentInput formatNewContent formatSystemInstruction generateContent generateContentStream generateResponseSequence getClientHeaders getFunctionCalls getHeaders getResponsePromise getResponseStream getText hadBadFinishReason makeRequest processStream registerVertex validateChatHistory	+ formatSystemInstruction

Type

Base (1aadc47)

Merge (392380a)

Diff

functions

23 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

24 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

+ formatSystemInstruction

`getGenerativeModel`

Size

Type	Base (1aadc47)	Merge (392380a)	Diff
size	15.9 kB	16.2 kB	+318 B (+2.0%)
size-with-ext-deps	34.3 kB	34.7 kB	+318 B (+0.9%)

Dependency

Type	Base (1aadc47)	Merge (392380a)	Diff
functions	24 dependencies addHelpers aggregateResponses assignRoleToPartsAndValidateSendMessageRequest buildFetchOptions constructRequest countTokens formatBlockErrorMessage formatGenerateContentInput formatNewContent generateContent generateContentStream generateResponseSequence getClientHeaders getFunctionCalls getGenerativeModel getHeaders getResponsePromise getResponseStream getText hadBadFinishReason makeRequest processStream registerVertex validateChatHistory	25 dependencies addHelpers aggregateResponses assignRoleToPartsAndValidateSendMessageRequest buildFetchOptions constructRequest countTokens formatBlockErrorMessage formatGenerateContentInput formatNewContent formatSystemInstruction generateContent generateContentStream generateResponseSequence getClientHeaders getFunctionCalls getGenerativeModel getHeaders getResponsePromise getResponseStream getText hadBadFinishReason makeRequest processStream registerVertex validateChatHistory	+ formatSystemInstruction

Type

Base (1aadc47)

Merge (392380a)

Diff

functions

24 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

25 dependencies

addHelpers
aggregateResponses
assignRoleToPartsAndValidateSendMessageRequest
buildFetchOptions
constructRequest
countTokens
formatBlockErrorMessage
formatGenerateContentInput
formatNewContent
formatSystemInstruction
generateContent
generateContentStream
generateResponseSequence
getClientHeaders
getFunctionCalls
getGenerativeModel
getHeaders
getResponsePromise
getResponseStream
getText
hadBadFinishReason
makeRequest
processStream
registerVertex
validateChatHistory

+ formatSystemInstruction

Test Logs

Base (1aadc47): https://github.com/firebase/firebase-js-sdk/actions/runs/8791882911
Merge (392380a): https://github.com/firebase/firebase-js-sdk/actions/runs/8854601415

firebase / firebase-js-sdk

Allow text-only systemInstruction #8208

⚠️ No Changeset found

Size Report ¹

Affected Products

`@firebase/vertexai`

`firebase`

Test Logs

Size Analysis Report ¹

Affected Products

`@firebase/vertexai`

`GenerativeModel`

`getGenerativeModel`

Test Logs

firebase / firebase-js-sdk

Allow text-only systemInstruction #8208

⚠️ No Changeset found

Size Report 1

Affected Products

@firebase/vertexai

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/vertexai

GenerativeModel

getGenerativeModel

Test Logs

Size Report ¹

`@firebase/vertexai`

`firebase`

Size Analysis Report ¹

`@firebase/vertexai`

`GenerativeModel`

`getGenerativeModel`