hsubox76 commented 2 weeks ago

Rename package (@firebase/) and top level entry point (firebase/) from "vertexai" to "vertexai-preview".
Fix any missed renames from "vertex" to "vertexAI"
Add NPM token for the new package to the 3 workflows that do NPM publishes (already added to Github secrets)
Add api-report npm script so that it will be picked up by the docgen process (will generate docs in a separate PR)
Fix comments flagged by api-documenter process
Add changeset (set vertexai-preview version to 0.0.0 and allow changesets to patch bump it to 0.0.1 on publish). Note the changeset will apply to the whole ch-vertex-feature branch being merged into master, so that's why it includes @firebase/app.

I did not rename the directory packages/vertexai because I didn't want this PR to have a 140 file diff. It should be fine, the dirname isn't published to NPM.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 57f6c0b65f9989a43f768152b4cbea0e8c9470f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

| Name | Type | | -------------------------- | ----- | | firebase | Minor | | @firebase/vertexai-preview | Patch | | @firebase/app | Patch | | @firebase/app-compat | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Report ¹

Affected Products

@firebase/app
Type Base (b981a45) Merge (a0a204a) Diff
browser 18.1 kB 18.1 kB +8 B (+0.0%)
esm5 23.7 kB 23.7 kB +8 B (+0.0%)
main 24.8 kB 24.8 kB +8 B (+0.0%)
module 18.1 kB 18.1 kB +8 B (+0.0%)
@firebase/vertexai-preview
Type Base (b981a45) Merge (a0a204a) Diff
browser ? 24.7 kB ? (?)
main ? 25.3 kB ? (?)
module ? 24.7 kB ? (?)

Type	Base (b981a45)	Merge (a0a204a)	Diff
browser	18.1 kB	18.1 kB	+8 B (+0.0%)
esm5	23.7 kB	23.7 kB	+8 B (+0.0%)
main	24.8 kB	24.8 kB	+8 B (+0.0%)
module	18.1 kB	18.1 kB	+8 B (+0.0%)

Type	Base (b981a45)	Merge (a0a204a)	Diff
browser	?	24.7 kB	? (?)
main	?	25.3 kB	? (?)
module	?	24.7 kB	? (?)

`bundle`

46 size changes

Type	Base (b981a45)	Merge (a0a204a)	Diff
analytics (logEvent)	44.5 kB	44.5 kB	+8 B (+0.0%)
app-check (CustomProvider)	37.3 kB	37.3 kB	+8 B (+0.0%)
app-check (ReCaptchaEnterpriseProvider)	39.9 kB	39.9 kB	+8 B (+0.0%)
app-check (ReCaptchaV3Provider)	39.8 kB	39.8 kB	+8 B (+0.0%)
auth (Anonymous)	76.0 kB	76.0 kB	+8 B (+0.0%)
auth (EmailAndPassword)	84.3 kB	84.3 kB	+8 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	103 kB	103 kB	+8 B (+0.0%)
auth (GooglePopup)	100 kB	100 kB	+8 B (+0.0%)
auth (GoogleRedirect)	101 kB	101 kB	+8 B (+0.0%)
auth (Phone)	86.7 kB	86.7 kB	+8 B (+0.0%)
database (Append to a list of data)	149 kB	149 kB	+8 B (+0.0%)
database (Filtering data)	148 kB	148 kB	+8 B (+0.0%)
database (Listen for child events)	164 kB	164 kB	+8 B (+0.0%)
database (Listen for value events + Detach listeners)	164 kB	164 kB	+8 B (+0.0%)
database (Listen for value events)	164 kB	164 kB	+8 B (+0.0%)
database (Read data once)	164 kB	164 kB	+8 B (+0.0%)
database (Save data as transactions)	166 kB	166 kB	+8 B (+0.0%)
database (Sort data)	149 kB	150 kB	+8 B (+0.0%)
database (Write data)	148 kB	148 kB	+8 B (+0.0%)
firestore (CSI Auto Indexing Disable and Delete)	270 kB	270 kB	+8 B (+0.0%)
firestore (CSI Auto Indexing Enable)	270 kB	270 kB	+8 B (+0.0%)
firestore (Persistence)	305 kB	305 kB	+8 B (+0.0%)
firestore (Query Cursors)	242 kB	242 kB	+8 B (+0.0%)
firestore (Query)	240 kB	240 kB	+8 B (+0.0%)
firestore (Read data once)	228 kB	228 kB	+8 B (+0.0%)
firestore (Read Write w Persistence)	325 kB	325 kB	+8 B (+0.0%)
firestore (Realtime updates)	230 kB	230 kB	+8 B (+0.0%)
firestore (Transaction)	207 kB	207 kB	+8 B (+0.0%)
firestore (Write data)	207 kB	207 kB	+8 B (+0.0%)
firestore-lite (Query Cursors)	89.8 kB	89.8 kB	+8 B (+0.0%)
firestore-lite (Query)	85.9 kB	85.9 kB	+8 B (+0.0%)
firestore-lite (Read data once)	62.1 kB	62.1 kB	+8 B (+0.0%)
firestore-lite (Transaction)	87.0 kB	87.1 kB	+8 B (+0.0%)
firestore-lite (Write data)	71.7 kB	71.7 kB	+8 B (+0.0%)
functions (call)	31.9 kB	31.9 kB	+8 B (+0.0%)
messaging (send + receive)	46.8 kB	46.9 kB	+8 B (+0.0%)
performance (trace)	51.7 kB	51.7 kB	+8 B (+0.0%)
remote-config (getAndFetch)	46.2 kB	46.2 kB	+8 B (+0.0%)
storage (getBytes)	42.0 kB	42.0 kB	+8 B (+0.0%)
storage (getDownloadURL)	44.1 kB	44.1 kB	+8 B (+0.0%)
storage (getMetadata)	43.5 kB	43.5 kB	+8 B (+0.0%)
storage (list + listAll)	42.9 kB	43.0 kB	+8 B (+0.0%)
storage (updateMetadata)	43.8 kB	43.8 kB	+8 B (+0.0%)
storage (uploadBytes)	48.6 kB	48.7 kB	+8 B (+0.0%)
storage (uploadBytesResumable)	58.6 kB	58.6 kB	+8 B (+0.0%)
storage (uploadString)	48.9 kB	48.9 kB	+8 B (+0.0%)

`firebase`

Type	Base (b981a45)	Merge (a0a204a)	Diff
firebase-app-compat.js	31.4 kB	31.4 kB	+8 B (+0.0%)
firebase-app.js	102 kB	102 kB	+8 B (+0.0%)
firebase-compat.js	788 kB	788 kB	+8 B (+0.0%)
firebase-performance-standalone-compat.es2017.js	93.3 kB	93.3 kB	+8 B (+0.0%)
firebase-performance-standalone-compat.js	70.4 kB	70.4 kB	+8 B (+0.0%)
firebase-vertexai-preview.js	?	18.9 kB	? (?)

Test Logs

Base (b981a45): https://github.com/firebase/firebase-js-sdk/actions/runs/8929442058
Merge (a0a204a): https://github.com/firebase/firebase-js-sdk/actions/runs/8974175753

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Analysis Report ¹

This report is too large (176,140 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

Base (b981a45): https://github.com/firebase/firebase-js-sdk/actions/runs/8929442058
Merge (37a4653): https://github.com/firebase/firebase-js-sdk/actions/runs/8929519722

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Analysis Report ¹

This report is too large (176,140 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

Base (b981a45): https://github.com/firebase/firebase-js-sdk/actions/runs/8929442058
Merge (a0a204a): https://github.com/firebase/firebase-js-sdk/actions/runs/8974175753

firebase / firebase-js-sdk

Prepare for public preview release #8214

🦋 Changeset detected

Size Report ¹

Affected Products

`@firebase/app`

`@firebase/vertexai-preview`

`bundle`

`firebase`

Test Logs

Size Analysis Report ¹

Test Logs

Size Analysis Report ¹

Test Logs

firebase / firebase-js-sdk

Prepare for public preview release #8214

🦋 Changeset detected

Size Report 1

Affected Products

@firebase/app

@firebase/vertexai-preview

bundle

firebase

Test Logs

Size Analysis Report 1

Test Logs

Size Analysis Report 1

Test Logs

Size Report ¹

`@firebase/app`

`@firebase/vertexai-preview`

`bundle`

`firebase`

Size Analysis Report ¹

Size Analysis Report ¹