hsubox76 commented 2 weeks ago

Revert the location part of https://github.com/firebase/firebase-js-sdk/pull/8124 and allow user to set location again.

Also get rid of some TS errors on SafetyRatings in tests.

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: a49dc31404f444744cf97cfd98e0c9d862789bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Report ¹

Affected Products

@firebase/vertexai
Type Base (b981a45) Merge (85ee540) Diff
browser 24.4 kB 24.6 kB +216 B (+0.9%)
main 25.0 kB 25.2 kB +216 B (+0.9%)
module 24.4 kB 24.6 kB +216 B (+0.9%)
firebase
Type Base (b981a45) Merge (85ee540) Diff
firebase-vertexai.js 18.8 kB 18.9 kB +149 B (+0.8%)

Type	Base (b981a45)	Merge (85ee540)	Diff
browser	24.4 kB	24.6 kB	+216 B (+0.9%)
main	25.0 kB	25.2 kB	+216 B (+0.9%)
module	24.4 kB	24.6 kB	+216 B (+0.9%)

Type	Base (b981a45)	Merge (85ee540)	Diff
firebase-vertexai.js	18.8 kB	18.9 kB	+149 B (+0.8%)

Test Logs

Base (b981a45): https://github.com/firebase/firebase-js-sdk/actions/runs/8929442058
Merge (85ee540): https://github.com/firebase/firebase-js-sdk/actions/runs/8973039890

google-oss-bot commented 2 weeks ago

<!DOCTYPE html>

Size Analysis Report ¹

Affected Products

@firebase/vertexai
- BlockReason
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.41 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- ChatSession
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 14.0 kB 14.1 kB +118 B (+0.8%)
  size-with-ext-deps 32.4 kB 32.5 kB +118 B (+0.4%)
- FinishReason
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.41 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- FunctionCallingMode
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.42 kB 3.54 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- FunctionDeclarationSchemaType
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.43 kB 3.55 kB +118 B (+3.4%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- GenerativeModel
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 16.2 kB 16.3 kB +118 B (+0.7%)
  size-with-ext-deps 34.6 kB 34.7 kB +118 B (+0.3%)
- HarmBlockMethod
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.42 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- HarmBlockThreshold
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.42 kB 3.54 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- HarmCategory
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.41 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- HarmProbability
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.42 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- HarmSeverity
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.41 kB 3.53 kB +118 B (+3.5%)
  size-with-ext-deps 21.1 kB 21.2 kB +118 B (+0.6%)
- POSSIBLE_ROLES
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.46 kB 3.58 kB +118 B (+3.4%)
  size-with-ext-deps 21.1 kB 21.3 kB +118 B (+0.6%)
- getGenerativeModel
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 16.2 kB 16.4 kB +118 B (+0.7%)
  size-with-ext-deps 34.7 kB 34.8 kB +118 B (+0.3%)
- getVertexAI
  Size
  Type Base (b981a45) Merge (85ee540) Diff
  size 3.54 kB 3.71 kB +162 B (+4.6%)
  size-with-ext-deps 28.5 kB 28.7 kB +162 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.41 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	14.0 kB	14.1 kB	+118 B (+0.8%)
size-with-ext-deps	32.4 kB	32.5 kB	+118 B (+0.4%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.41 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.42 kB	3.54 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.43 kB	3.55 kB	+118 B (+3.4%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	16.2 kB	16.3 kB	+118 B (+0.7%)
size-with-ext-deps	34.6 kB	34.7 kB	+118 B (+0.3%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.42 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.42 kB	3.54 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.41 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.42 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.41 kB	3.53 kB	+118 B (+3.5%)
size-with-ext-deps	21.1 kB	21.2 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.46 kB	3.58 kB	+118 B (+3.4%)
size-with-ext-deps	21.1 kB	21.3 kB	+118 B (+0.6%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	16.2 kB	16.4 kB	+118 B (+0.7%)
size-with-ext-deps	34.7 kB	34.8 kB	+118 B (+0.3%)

Type	Base (b981a45)	Merge (85ee540)	Diff
size	3.54 kB	3.71 kB	+162 B (+4.6%)
size-with-ext-deps	28.5 kB	28.7 kB	+162 B (+0.6%)

Test Logs

Base (b981a45): https://github.com/firebase/firebase-js-sdk/actions/runs/8929442058
Merge (85ee540): https://github.com/firebase/firebase-js-sdk/actions/runs/8973039890

firebase / firebase-js-sdk

[VertexAI] Allow user to set location #8219

⚠️ No Changeset found

Size Report ¹

Affected Products

`@firebase/vertexai`

`firebase`

Test Logs

Size Analysis Report ¹

Affected Products

`@firebase/vertexai`

`BlockReason`

`ChatSession`

`FinishReason`

`FunctionCallingMode`

`FunctionDeclarationSchemaType`

`GenerativeModel`

`HarmBlockMethod`

`HarmBlockThreshold`

`HarmCategory`

`HarmProbability`

`HarmSeverity`

`POSSIBLE_ROLES`

`getGenerativeModel`

`getVertexAI`

Test Logs

firebase / firebase-js-sdk

[VertexAI] Allow user to set location #8219

⚠️ No Changeset found

Size Report 1

Affected Products

@firebase/vertexai

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/vertexai

BlockReason

ChatSession

FinishReason

FunctionCallingMode

FunctionDeclarationSchemaType

GenerativeModel

HarmBlockMethod

HarmBlockThreshold

HarmCategory

HarmProbability

HarmSeverity

POSSIBLE_ROLES

getGenerativeModel

getVertexAI

Test Logs

Size Report ¹

`@firebase/vertexai`

`firebase`

Size Analysis Report ¹

`@firebase/vertexai`

`BlockReason`

`ChatSession`

`FinishReason`

`FunctionCallingMode`

`FunctionDeclarationSchemaType`

`GenerativeModel`

`HarmBlockMethod`

`HarmBlockThreshold`

`HarmCategory`

`HarmProbability`

`HarmSeverity`

`POSSIBLE_ROLES`

`getGenerativeModel`

`getVertexAI`