search

firebase / firebase-js-sdk

Firebase Javascript SDK
https://firebase.google.com/docs/web/setup
Other
4.84k stars 889 forks source link

signInWithPopup() lacks API to pass size hints #8612

Open ensonic opened 1 hour ago

ensonic commented 1 hour ago

Operating System

Any

Environment (if applicable)

Google Chrome 130.0.6723.58 (Official Build) (64-bit)

Firebase SDK Version

10.12.0

Firebase SDK Product(s)

Auth

Project Tooling

Angular app.

Detailed Problem Description

We use signInWithPopup() also with customOIDC providers. For some providers the popup cuts off the login button (at the button of the popup). The window size is hardcoded to 500 x 600 in https://github.com/firebase/firebase-js-sdk/blob/b807119252dacf46b0122344c2b6dfc503cecde1/packages/auth/src/platform_browser/util/popup.ts#L36-L37

The parameters are not exposed publicly as it seems (please correct me if I am wrong).

In the past I could see the default for known providers in idp.js (see e.g. https://github.com/firebase/firebase-js-sdk/pull/2966/files).

The file was removed in a huge PR #5345, that is hard to read and reason to see where things went.

Steps and code to reproduce issue

See problem desc

google-oss-bot commented 1 hour ago

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.