firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 917 forks source link

`sql:migrate --force` should ignore invalid connector #7199

Closed fredzqm closed 1 month ago

fredzqm commented 1 month ago

Description

CI/CD CUJ on non-prod workflow should set cloud sql state to whatever is in local configs. The following two commands should always work regardless of destructive schema migration of invalid connectors.

firebase dataconnect:sql:migrate --force
firebase deploy --only dataconnect --force

Previous, dataconnect:sql:migrate --force aborts upon invalid connector. This PR handles this edge case.

Scenarios Tested

firebase deploy with invalid connectors

Screenshot 2024-05-21 at 8 38 47 AM

firebase dataconnect:sql:migrate with invalid connectors

Screenshot 2024-05-21 at 8 39 52 AM

firebase dataconnect:sql:migrate --force with invalid connectors

Screenshot 2024-05-21 at 8 43 37 AM

Sample Commands