firebase / firebase-tools

The Firebase Command Line Tools
MIT License
3.97k stars 917 forks source link

`sql:migrate --force` shouldn't prompt #7208

Closed fredzqm closed 1 month ago

fredzqm commented 1 month ago

Description

firebase dataconnect:sql:migrate --force should never prompt.

firebase dataconnect:sql:migrate should prompt for schema migrations and then abort if there is invalid connectors. This way developers can see the SQL before taking the suggesting and run it with --force.

Scenarios Tested

Sample Commands

Without invalid connectors

firebase dataconnect:sql:migrate

Screenshot 2024-05-22 at 12 20 37 PM

firebase dataconnect:sql:migrate --force

Screenshot 2024-05-22 at 12 21 27 PM

With invalid connectors

firebase dataconnect:sql:migrate

Screenshot 2024-05-22 at 12 23 41 PM

firebase dataconnect:sql:migrate --force

Screenshot 2024-05-22 at 12 24 44 PM
fredzqm commented 1 month ago

Thanks!

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 54.06%. Comparing base (c94b5ab) to head (1ab7ed2). Report is 43 commits behind head on master.

Files Patch % Lines
src/dataconnect/schemaMigration.ts 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7208 +/- ## ========================================== - Coverage 54.10% 54.06% -0.05% ========================================== Files 387 386 -1 Lines 26094 26108 +14 Branches 5358 5361 +3 ========================================== - Hits 14119 14115 -4 - Misses 10715 10733 +18 Partials 1260 1260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.